Fix accessibility regressions in sidebar and docs page#2353
Fix accessibility regressions in sidebar and docs page#2353github-actions[bot] wants to merge 4 commits intomainfrom
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Organization UI (inherited) Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThis PR modifies styling in two components to adjust color and typography properties. In AppSidebar.tsx, the ExpandMoreIcon color changes from Possibly related PRs
🚥 Pre-merge checks | ✅ 1 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Comment |
✅ UI Smoke Test Review —
|
| Total | Passed | Failed | Flaky | Skipped |
|---|---|---|---|---|
| 11 | 11 | 0 | 0 | 0 |
Individual test results
| Status | Test | Duration |
|---|---|---|
| ✅ | onboarding user reaches the connect entrypoint from the welcome screen | 640ms |
| ✅ | add data entrypoint exposes the technology picker and step 2 | 1622ms |
| ✅ | metrics user connects, picks a metric, and gets a line chart-ready result | 2115ms |
| ✅ | traces user opens a trace and pivots from service map context into Query Lab | 2129ms |
| ✅ | security-focused user validates auth tab switching before submitting credentials | 670ms |
| ✅ | ops user confirms connection guardrails and can reset back to the landing state | 2543ms |
| ✅ | query lab preserves query text and results after navigating to Console and back | 2540ms |
| ✅ | logs explorer route is available and runs a logs query | 1978ms |
| ✅ | logs landing page dimension drill-down opens query lab with selected filter | 1860ms |
| ✅ | task manager, ILM, and templates pages render with headings | 1709ms |
| ✅ | pages have no axe accessibility violations | 15673ms |
📸 Screenshot Preflight
Result: ✅ Clean — no errors detected
No console errors, page errors, or UI alerts detected.
💡 Recommendations
- ✨ All smoke tests pass and no UI errors detected. Ready for review.
📎 Full diagnostics and screenshots: workflow run
|
Checked this branch against the latest What is this? | From workflow: Address Merge Conflict Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not. |
Resolve merge conflict in DocsPage by keeping accessible markdown pre rendering and updated inline code styling. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Summary
This PR addresses the accessibility regressions reported in #2281.
Changes made
peek/src/components/AppSidebar.tsxby usingtext.primaryfor section labels and expand indicators.peek/src/components/DocsPage.tsxby rendering section titles ash2elements (Typographyvariant="h6" component="h2").color: text.primary, stronger code styling background).<pre tabIndex={0}>inReactMarkdowncomponents to satisfy scrollable-region focus requirements.Validation
make formatmake lintmake buildtests/component/DocsPage.test.tsxtests/component/AppSidebar.test.tsxtests/component/App.test.tsxAll checks passed locally in CI environment.
What is this? | From workflow: Mention in Issue
Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not.