Skip to content

Fix accessibility regressions in sidebar and docs page#2353

Open
github-actions[bot] wants to merge 4 commits intomainfrom
fix/issue-2281-a11y-regressions-c911874ace8edfd2
Open

Fix accessibility regressions in sidebar and docs page#2353
github-actions[bot] wants to merge 4 commits intomainfrom
fix/issue-2281-a11y-regressions-c911874ace8edfd2

Conversation

@github-actions
Copy link
Copy Markdown
Contributor

Summary

This PR addresses the accessibility regressions reported in #2281.

Changes made

  • Increased navigation section heading contrast in peek/src/components/AppSidebar.tsx by using text.primary for section labels and expand indicators.
  • Fixed Docs section heading semantics in peek/src/components/DocsPage.tsx by rendering section titles as h2 elements (Typography variant="h6" component="h2").
  • Improved inline code readability on Docs by increasing emphasis (color: text.primary, stronger code styling background).
  • Made markdown code blocks keyboard-focusable by rendering <pre tabIndex={0}> in ReactMarkdown components to satisfy scrollable-region focus requirements.

Validation

  • make format
  • make lint
  • make build
  • Pre-commit targeted tests (automatically run by hooks):
    • tests/component/DocsPage.test.tsx
    • tests/component/AppSidebar.test.tsx
    • tests/component/App.test.tsx

All checks passed locally in CI environment.


What is this? | From workflow: Mention in Issue

Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not.

github-actions Bot and others added 2 commits March 10, 2026 21:33
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@strawgate strawgate marked this pull request as ready for review March 10, 2026 21:36
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Mar 10, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: ASSERTIVE

Plan: Pro

Run ID: b10cff12-2074-4194-9e06-2208450febce

📥 Commits

Reviewing files that changed from the base of the PR and between 63719f1 and 7f12eba.

📒 Files selected for processing (2)
  • peek/src/components/AppSidebar.tsx
  • peek/src/components/DocsPage.tsx

📝 Walkthrough

Walkthrough

This PR modifies styling in two components to adjust color and typography properties. In AppSidebar.tsx, the ExpandMoreIcon color changes from text.secondary to text.primary. In DocsPage.tsx, code block styling is updated by switching the background from action.selected to background.subtle and adding fontWeight: 500 to code typography. No logic or behavioral changes are present.

Possibly related PRs

🚥 Pre-merge checks | ✅ 1 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Linked Issues check ⚠️ Warning PR partially addresses issue #2281 but incompletely: sidebar contrast fixed [#2281-1], but heading semantics [#2281-2] and scrollable code blocks focusability [#2281-3] are missing. Add fixes for Docs heading semantics (render as h2 instead of h6) and make pre elements keyboard-focusable with tabIndex={0} to fully resolve #2281.
✅ Passed checks (1 passed)
Check name Status Explanation
Out of Scope Changes check ✅ Passed All changes are scoped to accessibility fixes in AppSidebar.tsx and DocsPage.tsx files, directly addressing #2281 requirements.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/issue-2281-a11y-regressions-c911874ace8edfd2
  • 🛠️ Update Documentation: Commit on current branch
  • 🛠️ Update Documentation: Create PR

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown
Contributor Author

✅ UI Smoke Test Review — 6bd70c6

🎭 Smoke Test Results

Status: ✅ All passed

Total Passed Failed Flaky Skipped
11 11 0 0 0
Individual test results
Status Test Duration
onboarding user reaches the connect entrypoint from the welcome screen 640ms
add data entrypoint exposes the technology picker and step 2 1622ms
metrics user connects, picks a metric, and gets a line chart-ready result 2115ms
traces user opens a trace and pivots from service map context into Query Lab 2129ms
security-focused user validates auth tab switching before submitting credentials 670ms
ops user confirms connection guardrails and can reset back to the landing state 2543ms
query lab preserves query text and results after navigating to Console and back 2540ms
logs explorer route is available and runs a logs query 1978ms
logs landing page dimension drill-down opens query lab with selected filter 1860ms
task manager, ILM, and templates pages render with headings 1709ms
pages have no axe accessibility violations 15673ms

📸 Screenshot Preflight

Result: ✅ Clean — no errors detected

No console errors, page errors, or UI alerts detected.

💡 Recommendations

  • ✨ All smoke tests pass and no UI errors detected. Ready for review.

📎 Full diagnostics and screenshots: workflow run

@github-actions
Copy link
Copy Markdown
Contributor Author

Checked this branch against the latest main and there are currently no merge conflicts to resolve, so no code changes were needed.


What is this? | From workflow: Address Merge Conflict

Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not.

Resolve merge conflict in DocsPage by keeping accessible markdown pre rendering and updated inline code styling.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[love] Accessibility regressions: widespread color contrast failures and Docs semantic issues

1 participant