Conversation
1b99bf2 to
90bf326
Compare
90bf326 to
51f3130
Compare
|
deferring to @TiberiuGC / @cheeseandcereal |
|
It looks like this issue is due to merging this: #8242 Are there any other tools we use there in any of our makefiles that might have been accidentally removed? |
|
@cheeseandcereal I don't think so - based on this it looks like its just the gingko dep that is missing, I temporarily re-added it here to verify and see if anything else failed due to something missing. Tests are nearly all passing, but seeing same failures as what is on |
|
Ok, seems good for now then |
|
Do we need to update the build image tag for this? Or are we ok just leaving the old one for now until we remove it. Just asking because we'd also have to update it in the ci repo as well and coordinate that. But with tests already failing there, I'm not even sure if this necessarily works or not, and looks like we're planning to remove it (hopefully) shortly anyways. Thoughts? |
|
ya thats a tricky one - I didn't update it at first but it fails the required check then https://github.com/eksctl-io/eksctl/actions/runs/13545376316/job/37855584038?pr=8251 but if we can bypass and then hopefully get to where we can drop this build image coordination stuff, that would be ideal. I'm open to either way as long as we can get closer to dropping the build image update/coordination steps (we seem to be quite close) |
|
closing in favor of #8257 to revert |
Description
Temporarily added here to satisfy this error:
Checklist
README.md, or theuserdocsdirectory)area/nodegroup) and kind (e.g.kind/improvement)BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯