Skip to content

Enable auto-update of ec2 info #8239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dims merged 1 commit into from
Feb 21, 2025
Merged

Enable auto-update of ec2 info #8239

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion .github/workflows/update-generated.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:
strategy:
fail-fast: false
matrix:
resource: ["coredns", "aws-node", "nvidia-device-plugin"]
resource: ["coredns", "aws-node", "nvidia-device-plugin", "ec2-info"]
name: Update ${{ matrix.resource }} and open PR
runs-on: ubuntu-latest
container: public.ecr.aws/eksctl/eksctl-build:26e3c36557da8ae2db5d995cea673e05cc60cfce
Expand All @@ -35,6 +35,14 @@ jobs:
role-duration-seconds: 900
role-session-name: eksctl-update-coredns-assets
role-to-assume: ${{ secrets.UPDATE_COREDNS_ROLE_ARN }}
- name: Configure AWS credentials for ec2 info update
if: ${{ matrix.resource == 'ec2-info' }}
uses: aws-actions/configure-aws-credentials@ececac1a45f3b08a01d2dd070d28d111c5fe6722 # v4.1.0
with:
aws-region: us-west-2
role-duration-seconds: 900
role-session-name: eksctl-update-ec2-info-assets
role-to-assume: ${{ secrets.UPDATE_EC2_INFO_ROLE_ARN }}
Copy link
Contributor

@bryantbiggs bryantbiggs Feb 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could probably just use one role that has list/describe permissions - if we need to scope it, we have session tags that can be used

Copy link
Contributor

@bryantbiggs bryantbiggs Feb 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we also need to ensure this doesn't run in an account that has preview access to new instance types that are not yet released

- name: Setup identity as eksctl-bot
uses: ./.github/actions/setup-identity
with:
Expand Down
4 changes: 4 additions & 0 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,6 +172,10 @@ update-aws-node: ## Re-download the aws-node manifests from AWS
update-coredns: ## get latest coredns builds for each available eks version
@go run pkg/addons/default/scripts/update_coredns_assets.go

.PHONY:
update-ec2-info: ## get latest info on ec2 instance types
@go run cmd/ec2geninfo/main.go

deep_copy_helper_input = $(shell $(call godeps_cmd,./pkg/apis/...) | sed 's|$(generated_code_deep_copy_helper)||' )
$(generated_code_deep_copy_helper): $(deep_copy_helper_input) ## Generate Kubernetes API helpers
build/scripts/update-codegen.sh
Expand Down
2 changes: 1 addition & 1 deletion cmd/ec2geninfo/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ func updateEC2Instances() error {
return err
}

file, err := os.Create("../../pkg/utils/instance/instance_types.go")
file, err := os.Create("pkg/utils/instance/instance_types.go")
if err != nil {
return err
}
Expand Down
2 changes: 1 addition & 1 deletion pkg/utils/instance/instance_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5242,7 +5242,7 @@ var InstanceTypes = []InstanceInfo{
InstanceStorageSupported: true,
EFASupported: true,
NvidiaGPUSupported: true,
NvidiaGPUType: "NVIDIA",
NvidiaGPUType: "H200",
NeuronSupported: false,
NeuronDeviceType: "",
CBRSupported: true,
Expand Down
Loading