Conversation
bryantbiggs
added
skip-release-notes
bryantbiggs
force-pushed
the
chore/remove-build-image
branch
from
10a2a64 to
fc8961b
Compare
| rc: | ||
| name: Push release candidate tag | ||
| runs-on: ubuntu-latest | ||
| container: public.ecr.aws/eksctl/eksctl-build:26e3c36557da8ae2db5d995cea673e05cc60cfce |
There was a problem hiding this comment.
removing the build image was previously reverted because these container references were not cleaned up from the CI scripts, which caused the subsequent release to fail due to image not found
cheeseandcereal
left a comment
cheeseandcereal
left a comment
There was a problem hiding this comment.
Changes also need to be made in the other repos in this org to support these changes
Makefile
Outdated
| ##@ Dependencies | ||
| .PHONY: install-all-deps | ||
| install-all-deps: install-build-deps install-site-deps ## Install all dependencies for building both binary and user docs) | ||
| install-all-deps: install-site-deps ## Install all dependencies for building both binary and user docs) |
There was a problem hiding this comment.
why is install-all-deps no longer installing the other dependencies?
There was a problem hiding this comment.
this looks like a mistake - will re-add
Makefile
Outdated
| .PHONY: install-tools | ||
| install-tools: ## Install dependencies for code generation and test execution |
There was a problem hiding this comment.
Is there a reason for renaming this target? There are other references to the old target name install-build-deps in various other places that also need to be updated.
There was a problem hiding this comment.
its a bit mis-leading, the aren't just build deps but also deps required for testing (cert generation), and this matched the tools.go a bit better. I can go either way though - let me know which way we want go and I'll make sure any references are updated
Pull request was converted to draft
bryantbiggs
force-pushed
the
chore/remove-build-image
branch
from
e1dac30 to
959d51d
Compare
2 participants
Description
.requirementsfile has been removed; binaries/libs required for building/testing have been placed under theinstall-toolsmake command. Future: investigate usinggo tools ...which was added in 1.24build/docker/*directory and associated files are removed, removing the intermediate build image artifacts.github/workflows/ecr-publish-build.yamlworkflowMakefile.docker.github/workflows/build-all-distros-nightly.yamlworkflow is removed since its redundant of the CI checks, and has been failing for some timeChecklist
README.md, or theuserdocsdirectory)area/nodegroup) and kind (e.g.kind/improvement)BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯