Migrate goformation under pkg/ as a local package and remove location re-write#8218
Closed
bryantbiggs wants to merge 2 commits intoeksctl-io:mainfrom
Closed
Migrate goformation under pkg/ as a local package and remove location re-write#8218bryantbiggs wants to merge 2 commits intoeksctl-io:mainfrom
goformation under pkg/ as a local package and remove location re-write#8218bryantbiggs wants to merge 2 commits intoeksctl-io:mainfrom
Conversation
a965dbe to
f831d81
Compare
Member
|
These changes largely look good to me. I have 2 asks:
|
Contributor
Author
Contributor
Author
|
moved to #8219 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
goformationunderpkg/as a local package and remove location re-writeThis is to resolve the reported security findings shown here https://github.com/eksctl-io/eksctl/security/dependabot
This is a repeat of #8153 which was reverted since it was caught up in the changes with the failed build image #8157
The steps used to create this PR are as follows (to better understand due to large number of path re-write changes):
goformationdirectory underpkg/goformationreferences from the maingo.modfilego.modandgo.sumfrompkg/goformation/*goformation(find ./ -type f -name '*.go' -exec sed -i 's|awslabs/goformation/v4|weaveworks/eksctl/pkg/goformation|g' {} \;)go mod tidymake buildmake unit-test-no-generateto testChecklist
README.md, or theuserdocsdirectory)area/nodegroup) and kind (e.g.kind/improvement)BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯