Remove build image reference from release workflow, consolidate go setup in GitHub actions#8158
Closed
bryantbiggs wants to merge 1 commit intoeksctl-io:mainfrom
Closed
Remove build image reference from release workflow, consolidate go setup in GitHub actions#8158bryantbiggs wants to merge 1 commit intoeksctl-io:mainfrom
bryantbiggs wants to merge 1 commit intoeksctl-io:mainfrom
Conversation
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
container: public.ecr.aws/eksctl/eksctl-build:...references; this image is no longer used and does not appear to have any bearing on the CI release process - the artifacts will be build directly in the GitHub runner environmentactions/cacheactions for caching go depdencies - this is already handled by the internal.github/actions/setup-buildactionactions/setup-goactions for installing go - this is already handled by the internal.github/actions/setup-buildaction which means less places to remember to update the go version in the futuresecrets.EKSCTLBOT_TOKENusage fromactions/checkout- this should be necessary given that the code is publicly availablemainChecklist
README.md, or theuserdocsdirectory)area/nodegroup) and kind (e.g.kind/improvement)BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯