Skip to content

Downgrade go to 1.21 due to build image version#8156

Closed
bryantbiggs wants to merge 3 commits intoeksctl-io:mainfrom
bryantbiggs:chore/downgrade-go
Closed

Downgrade go to 1.21 due to build image version#8156
bryantbiggs wants to merge 3 commits intoeksctl-io:mainfrom
bryantbiggs:chore/downgrade-go

Conversation

@bryantbiggs
Copy link
Contributor

@bryantbiggs bryantbiggs commented Jan 22, 2025

Description

On a bright note, look how few changes are required for changing a go version 🎉 (was only 4 lines, but the way the CI lint check works, had to run make build to give it something to check 😐 )

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the userdocs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes
  • (Core team) Added labels for change area (e.g. area/nodegroup) and kind (e.g. kind/improvement)

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

@bryantbiggs bryantbiggs added the skip-release-notes Causes PR not to show in release notes label Jan 22, 2025
@bryantbiggs
Copy link
Contributor Author

closing in favor of #8157 for now

@bryantbiggs bryantbiggs deleted the chore/downgrade-go branch January 22, 2025 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-release-notes Causes PR not to show in release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant