Fix Github workflow for updating generated files for default addons#7766
Merged
Fix Github workflow for updating generated files for default addons#7766
Conversation
TiberiuGC
changed the title
TiberiuGC
force-pushed
the
bugfix/update-generated-files
branch
from
c521b08 to
888e903
Compare
TiberiuGC
force-pushed
the
bugfix/update-generated-files
branch
from
f54465a to
c1c06cf
Compare
Closed
cPu1
approved these changes
Jun 7, 2024
TiberiuGC
force-pushed
the
bugfix/update-generated-files
branch
from
c1c06cf to
a33bfab
Compare
This was referenced Jun 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The Github workflow responsible for upgrading the manifests for default
aws-nodeandcorednsaddons has been broken for a while.https://github.com/eksctl-io/eksctl/actions/workflows/update-generated.yaml
This PR aims to provide a fix for that. People have been experiencing issues with
eksctl utils updatecommands since the generated files were out of date for long period of time. e.g. #7755Additionally, the PR includes a fix for the
update corednsPR, as in, it excludespreviewversions when trying to resolve the latest. Manual test for that #7767Checklist
README.md, or theuserdocsdirectory)area/nodegroup) and kind (e.g.kind/improvement)BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯