Fix arn build logic to support different aws partitions#7715
Merged
cPu1 merged 1 commit intoeksctl-io:mainfrom Apr 23, 2024
Merged
Fix arn build logic to support different aws partitions#7715cPu1 merged 1 commit intoeksctl-io:mainfrom
cPu1 merged 1 commit intoeksctl-io:mainfrom
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Hello timandy 👋 Thank you for opening a Pull Request in eksctl project. The team will review the Pull Request and aim to respond within 1-10 business days. Meanwhile, please read about the Contribution and Code of Conduct guidelines here. You can find out more information about eksctl on our website
cPu1
reviewed
Apr 18, 2024
Contributor
cPu1
left a comment
cPu1
left a comment
There was a problem hiding this comment.
LGTM but we lack access to cn-northwest-1 and are unable to test this. Can you share some output, redacting any sensitive information, from the create fargateprofile command, and if possible, for EKS connector and Karpenter as well?
Contributor
Author
|
Hi @cPu1 , I have tested create fargate-profile and karpenter on cn-northwest-1 region, the logs is here. And the Trust Policy of FargatePodExecutionRole is But I have no condition to test register an external cluster, because I don't have an external cluster. |
Contributor
|
@timandy thanks for testing the two use cases. I will try to find out the ARN that should be used for EKS Connector. |
cPu1
approved these changes
Apr 23, 2024
Contributor
cPu1
left a comment
cPu1
left a comment
There was a problem hiding this comment.
LGTM. Thanks for the quick fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix #7713
Checklist
README.md, or theuserdocsdirectory)area/nodegroup) and kind (e.g.kind/improvement)BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯