Include MixedInstancesPolicy LaunchTemplate for validation#7661
Merged
yuxiang-zhang merged 1 commit intoeksctl-io:mainfrom Mar 22, 2024
Merged
Include MixedInstancesPolicy LaunchTemplate for validation#7661yuxiang-zhang merged 1 commit intoeksctl-io:mainfrom
yuxiang-zhang merged 1 commit intoeksctl-io:mainfrom
Conversation
TiberiuGC
reviewed
Mar 20, 2024
Contributor
TiberiuGC
left a comment
TiberiuGC
left a comment
There was a problem hiding this comment.
Can we add an unit test for this?
Member
Author
👍 will do, I'm trying to confirm whether this solution is correct |
yuxiang-zhang
force-pushed
the
7644
branch
2 times, most recently
from
3ae0ed1 to
b07671c
Compare
TiberiuGC
approved these changes
Mar 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #7644
Checklist
README.md, or theuserdocsdirectory)area/nodegroup) and kind (e.g.kind/improvement)BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯