Fix coredns pdb preventing cluster deletion in integration tests#7496
Merged
yuxiang-zhang merged 1 commit intoeksctl-io:mainfrom Jan 23, 2024
Merged
Conversation
yuxiang-zhang
force-pushed
the
fix-coredns-cannot-be-evicted
branch
from
0c5a9ec to
ce6e6e6
Compare
yuxiang-zhang
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The coredns addon now has a default Pod Disruption Budget (PDB), and draining the nodes simply times out trying to evict the coredns pods. 3 integration tests have been failing in the cleanup step, and this PR fixes them use of the
--disable-nodegroup-evictionflag added in #4659 specifically for this purpose.Checklist
README.md, or theuserdocsdirectory)area/nodegroup) and kind (e.g.kind/improvement)BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯