Disallow passing a vpc.securityGroup with external security group rules#7030
Merged
cPu1 merged 2 commits intoeksctl-io:mainfrom Sep 5, 2023
Merged
Disallow passing a vpc.securityGroup with external security group rules#7030cPu1 merged 2 commits intoeksctl-io:mainfrom
cPu1 merged 2 commits intoeksctl-io:mainfrom
Conversation
cPu1
force-pushed
the
fix-unowned-sg
branch
2 times, most recently
from
6f82046 to
8a3934f
Compare
TiberiuGC
approved these changes
Sep 1, 2023
cPu1
force-pushed
the
fix-unowned-sg
branch
4 times, most recently
from
0b0e3e6 to
5d082c7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This changelist adds validation to disallow passing a
vpc.securityGroupwith external security group rules.Closes #6455
Checklist
README.md, or theuserdocsdirectory)area/nodegroup) and kind (e.g.kind/improvement)BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯