Skip to content

Add additional EFA supported instances.#5274

Merged
Himangini merged 3 commits intoeksctl-io:mainfrom
mhuguesaws:enhancement/#5090_add_efa_supported_instances
Jun 9, 2022
Merged

Add additional EFA supported instances.#5274
Himangini merged 3 commits intoeksctl-io:mainfrom
mhuguesaws:enhancement/#5090_add_efa_supported_instances

Conversation

@mhuguesaws
Copy link
Contributor

Close #5090

Description

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the userdocs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes
  • (Core team) Added labels for change area (e.g. area/nodegroup) and kind (e.g. kind/improvement)

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

@Himangini Himangini requested a review from a team May 16, 2022 16:24
@mhuguesaws mhuguesaws force-pushed the enhancement/#5090_add_efa_supported_instances branch from 6a8fcee to 630ce5a Compare May 16, 2022 21:10
@cPu1
Copy link
Contributor

cPu1 commented May 17, 2022

@mhuguesaws, was this list generated by running describe-instances with the EFA filter? What region did you specify?

aws ec2 describe-instance-types \ 
--filters Name=network-info.efa-supported,Values=true \ 
--query "InstanceTypes[*].[InstanceType]" \ 
--output text | sort

@mhuguesaws
Copy link
Contributor Author

mhuguesaws commented May 17, 2022

@cPu1 Region specified was us-east-1.
hpc6a.48xlarge is available in us-east-2.

@cPu1
Copy link
Contributor

cPu1 commented May 25, 2022

@cPu1 Region specified was us-east-1. hpc6a.48xlarge is available in us-east-2.

@mhuguesaws, are you able to generate a list containing the supported instance types across all regions in your account? I understand this list might differ across accounts, but it'll still be more exhaustive. Just this one change and the PR is good to merge.

@Himangini
Copy link
Contributor

@cPu1 Region specified was us-east-1. hpc6a.48xlarge is available in us-east-2.

@mhuguesaws, are you able to generate a list containing the supported instance types across all regions in your account? I understand this list might differ across accounts, but it'll still be more exhaustive. Just this one change and the PR is good to merge.

@cPu1 Region specified was us-east-1. hpc6a.48xlarge is available in us-east-2.

@mhuguesaws, are you able to generate a list containing the supported instance types across all regions in your account? I understand this list might differ across accounts, but it'll still be more exhaustive. Just this one change and the PR is good to merge.

@mhuguesaws hey 👋🏻 have you had a chance to add this? let us know if you need help or we can take this over 👍🏻

@mhuguesaws mhuguesaws force-pushed the enhancement/#5090_add_efa_supported_instances branch from f5a6072 to 0445e06 Compare June 8, 2022 13:36
@mhuguesaws mhuguesaws force-pushed the enhancement/#5090_add_efa_supported_instances branch from 0445e06 to 7ad54ae Compare June 8, 2022 13:46
@mhuguesaws
Copy link
Contributor Author

Updated PR with all instances supporting EFA across all regions.

I use

regions=$(aws ec2 describe-regions --output text --query 'Regions[*].[RegionName]' | sort)
rm instance_w_efa_uniq.txt
for i in $regions
do
instances=$(aws ec2 describe-instance-types --filters Name=network-info.efa-supported,Values=true --query InstanceTypes[*].InstanceType --region ${i} --output json | jq -r -c '.[]')
 for j in $instances
 do
   echo "${j}" >> instance_w_efa_uniq.txt
 done
done

cat instance_w_efa_uniq.txt | sort -u > efa_uniq.txt

Copy link
Contributor

@Himangini Himangini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature] Change EFA plugin Daemonset for the new instance type supporting EFA

3 participants