Skip to content

Add ec2:DescribeInstanceTypes to autoScaler policy statements#4664

Merged
aclevername merged 1 commit intoeksctl-io:mainfrom
PatTheSilent:main
Jan 20, 2022
Merged

Add ec2:DescribeInstanceTypes to autoScaler policy statements#4664
aclevername merged 1 commit intoeksctl-io:mainfrom
PatTheSilent:main

Conversation

@PatTheSilent
Copy link
Contributor

Description

Add ec2:DescribeInstanceTypes to autoScaler statements which is required by cluster-autoscaler 1.23.0

https://github.com/kubernetes/autoscaler/releases/tag/cluster-autoscaler-1.23.0

Note: The merging of #4468 means that the default configuration of the CA will now require an extra IAM permission - ec2:DescribeInstanceTypes

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the userdocs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes
  • (Core team) Added labels for change area (e.g. area/nodegroup) and kind (e.g. kind/improvement)

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

Copy link
Contributor

@cPu1 cPu1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Contributor

@aclevername aclevername left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @PatTheSilent

@aclevername aclevername merged commit d7fa41f into eksctl-io:main Jan 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants