Add integration test for associate, disassociate and get identityprovider by cPu1 · Pull Request #4501 · eksctl-io/eksctl

cPu1 · 2021-11-30T13:15:40Z

Description

Closes #4443, #4444, #4445

Checklist

Added tests that cover your change (if possible)
Added/modified documentation as required (such as the README.md, or the userdocs directory)
Manually tested
Made sure the title of the PR is a good description that can go into the release notes
(Core team) Added labels for change area (e.g. area/nodegroup) and kind (e.g. kind/improvement)

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

Backfilled missing tests for code in same general area 🎉
Refactored something and made the world a better place 🌟

cPu1 · 2021-12-01T10:55:49Z

integration/tests/identity_provider/identity_provider_test.go

+		UserPoolId:                 pool.UserPool.Id,
+		GenerateSecret:             aws.Bool(false),
+		SupportedIdentityProviders: aws.StringSlice([]string{"COGNITO"}),
+		// TODO this is likely not required, check if this can be removed.


I am going to open another issue for this, as it requires changing values for other fields.

cPu1 · 2021-12-01T11:05:16Z

Integration test passed locally.

Himangini

LGTM 👍🏻

integration/tests/identity_provider/identity_provider_test.go

aclevername · 2021-12-08T15:37:31Z

Integration test passed locally.

have you re-ran since the changes were made? Do we need any additional policies for out github action role to hit these APIs?

cPu1 · 2021-12-09T11:14:35Z

have you re-ran since the changes were made?

The tests are in progress right now.

Do we need any additional policies for out github action role to hit these APIs?

We do. I'm going to work on adding them.

cPu1 · 2021-12-09T12:29:02Z

The tests are in progress right now.

Integration tests passed for the new changes.

aclevername · 2021-12-09T16:35:48Z

have you re-ran since the changes were made?

The tests are in progress right now.

Do we need any additional policies for out github action role to hit these APIs?

We do. I'm going to work on adding them.

lets make sure the role & cf tempalte in eksctl-ci are updated before merging

cPu1 · 2021-12-13T09:08:52Z

have you re-ran since the changes were made?

The tests are in progress right now.

Do we need any additional policies for out github action role to hit these APIs?

We do. I'm going to work on adding them.

lets make sure the role & cf tempalte in eksctl-ci are updated before merging

Yeah, that's why I haven't merged it yet. I'm running the tests now after updating the role.

cPu1 force-pushed the identity-provider-test branch from b262067 to 410bb8c Compare November 30, 2021 13:23

cPu1 added area/testing area/tech-debt Leftover improvements in code, testing and building labels Nov 30, 2021

cPu1 force-pushed the identity-provider-test branch 2 times, most recently from 48958df to a47d4ae Compare November 30, 2021 14:36

cPu1 added the kind/improvement label Dec 1, 2021

cPu1 force-pushed the identity-provider-test branch from 1852447 to 012a982 Compare December 1, 2021 10:50

cPu1 commented Dec 1, 2021

View reviewed changes

Himangini approved these changes Dec 2, 2021

View reviewed changes

Himangini requested review from Skarlso, aclevername and nikimanoledaki December 2, 2021 12:23

Skarlso reviewed Dec 2, 2021

View reviewed changes

integration/tests/identity_provider/identity_provider_test.go Outdated Show resolved Hide resolved

aclevername reviewed Dec 2, 2021

View reviewed changes