Fix --wait issue for eksctl upgrade nodegroup command#3956
Merged
cPu1 merged 6 commits intoeksctl-io:mainfrom Jul 8, 2021
Merged
Fix --wait issue for eksctl upgrade nodegroup command#3956cPu1 merged 6 commits intoeksctl-io:mainfrom
cPu1 merged 6 commits intoeksctl-io:mainfrom
Conversation
vchetu
changed the title
Contributor
|
Thank you for opening a PR @vchetu, a member of the team will review shortly! |
cPu1
suggested changes
Jul 8, 2021
cPu1
reviewed
Jul 8, 2021
Contributor
|
Thanks for the PR, @vchetu. It needs just one more change and it's good to merge. |
cPu1
approved these changes
Jul 8, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3889
Description
Currently --wait flag is ignored while performing nodegroup upgrade action. This PR checks for wait flag and accordingly performs the action.
Checklist
README.md, or theuserdocsdirectory)area/nodegroup) and kind (e.g.kind/improvement)BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯