Avoid nodeGroups[0].name must be set validation error

[errordeveloper]

Description

This fixes #1164 and related cases of the same error. This is a regression that was introduced by #1116 and #1124.

Checklist

• Code compiles correctly (i.e make build)
• Added tests that cover your change (if possible)
• All unit tests passing (i.e. make test)
• Manually tested

[errordeveloper]

I'm, going to have a go at adding some unit test to cover this, possibly also integration tests.

[errordeveloper]

@cPu1 what do you make of the most recent commit?

[cPu1]

@cPu1 what do you make of the most recent commit?

LGTM.

The unit test is failing because the change to NewCreateClusterLoader isn't updated in configfile_test.go:126

[errordeveloper]

Yes, I'll fix the unit tests and try to add some new ones also....

[errordeveloper]

I'd like to add eksctl get ng to integration suite as well.

[cPu1]

Alternative way:

		loaderParams := []struct {
			configFile     string
			nodeGroupCount int
		}{
			{"01-simple-cluster.yaml", 1, true},
			{"02-custom-vpc-cidr-no-nodes.yaml", 0, true},
			{"03-two-nodegroups.yaml", 2, true},
			{"05-advanced-nodegroups.yaml", 3, true},
			{"07-ssh-keys.yaml", 5, true},
		}
		
		for _, loaderTest := range loaderParams {
			cmd := &Cmd{
				CobraCommand:      newCmd(),
				ClusterConfigFile: filepath.Join(examplesDir, loaderTest.configFile),
				ClusterConfig:     api.NewClusterConfig(),
				ProviderConfig:    &api.ProviderConfig{},
			}
		
			ngFilter := NewNodeGroupFilter()
		
			for _, withoutNodeGroup := range []bool{true, false} {
				Expect(NewCreateClusterLoader(cmd, ngFilter, nil, withoutNodeGroup).Load()).To(Succeed())
		
				Expect(ngFilter.ExcludeAll).To(Equal(withoutNodeGroup))
		
				Expect(cmd.ClusterConfig.NodeGroups).To(HaveLen(loaderTest.nodeGroupCount))
		
				_, err := cmd.NewCtl()
				Expect(err).ToNot(HaveOccurred())
		
			}
		}

[errordeveloper]

yeah, I thought about it, but didn't seem to make that much difference