Rename cmdutils.ResourceCmd to cmdutils.Cmd#1127
Merged
errordeveloper merged 1 commit intomasterfrom Aug 9, 2019
Merged
Conversation
errordeveloper
changed the title
cmdutils.ResourceCmd to cmdutils.Cmd
Contributor
Author
|
This is on top of #1124, I will rebase once it gets merged. |
errordeveloper
force-pushed
the
rename-resourcecmd
branch
2 times, most recently
from
69a6b10 to
5168b97
Compare
errordeveloper
commented
Aug 9, 2019
| // Cmd holds attributes that are common between commands; | ||
| // not all commands use each attribute, but but they can if needed | ||
| type Cmd struct { | ||
| CobraCommand *cobra.Command |
Contributor
Author
There was a problem hiding this comment.
I've changed this to avoid ambiguity, otherwise it'd be cmd.Command...
errordeveloper
force-pushed
the
rename-resourcecmd
branch
from
5168b97 to
ffaa036
Compare
errordeveloper
force-pushed
the
rename-resourcecmd
branch
from
ffaa036 to
525e29c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
cmdutils.ResourceCmdtocmdutils.Cmdcmdinstead ofrc(which was confusing) (as promissed in Refactor command functions #859 (comment))Checklist
make build)make test)