fix(asb): Bobs sqlite migration would cause Alice to fail with assertion#942
Merged
binarybaron merged 1 commit intomasterfrom Apr 1, 2026
Merged
fix(asb): Bobs sqlite migration would cause Alice to fail with assertion#942binarybaron merged 1 commit intomasterfrom
binarybaron merged 1 commit intomasterfrom
Conversation
…tion The migration used json_tree to find objects with an "xmr" key, but this also matched Alice states (which have xmr in state3). Added an explicit Bob-only filter to the target query. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
binarybaron
force-pushed
the
fix/broken-migr
branch
from
c6f57ac to
b698b8e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Medium Risk
Touches SQLite migration logic for
swap_statesJSON, so a mistake could corrupt or fail database startup, but the change is narrowly scoped to filtering and remains idempotent viajson_insert.Overview
Fixes an ASB startup failure caused by a previous SQLite migration that accidentally matched Alice state JSON when searching for
xmrkeys.Adds a v2 migration that only targets rows with
$.Bobpresent before insertingtx_punish_fee/punish_address, and updates the changelog to note the ASB migration-startup fix.Written by Cursor Bugbot for commit b698b8e. This will update automatically on new commits. Configure here.