fix(asb, controller): get-swaps (use correct state, harden exchange rate calculation)#939
Merged
Einliterflasche merged 1 commit intomasterfrom Mar 31, 2026
Merged
Conversation
There were two problems: - get-swaps assumed the first state of a swap is `AliceState::Started`, but that is not saved to the DB. Instead, `BtcLockTransactionSeen` is the first saved state. - Exchange rate calculation was fragile (floats, precision problem). Fixes: - Assume `BtcLockTransactionSeen` instead of `Started` - Use decimals for exchange rate calculation
Author
|
This should fix #930. |
|
Assuming you have tested, LGTM! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There were two problems:
AliceState::Started, but that is not saved to the DB. Instead,BtcLockTransactionSeenis the first saved state.Fixes:
BtcLockTransactionSeeninstead ofStarted