Skip to content

feat(asb): limit p2p connections#934

Merged
binarybaron merged 2 commits intomasterfrom
feat/asb-conn-limit-new
Mar 30, 2026
Merged

feat(asb): limit p2p connections#934
binarybaron merged 2 commits intomasterfrom
feat/asb-conn-limit-new

Conversation

@binarybaron
Copy link
Copy Markdown

@binarybaron binarybaron commented Mar 27, 2026

  • feat(asb): limit p2p connections to prevent DoS via resource exhaustion
  • feat(asb): enable debug info in Docker release builds for perf and stack traces

Note

Medium Risk
Touches core P2P/Tor connection handling and introduces new connection limiting behavior, which can affect reachability and load characteristics if mis-tuned.

Overview
Hardens ASB networking against resource-exhaustion/DoS. It adds libp2p connection_limits to cap pending/established inbound connections and per-peer connections, and improves logging when inbound connections are denied due to limits.

On the Tor onion-service path, add_onion_service now accepts a max_concurrent_rend_requests parameter and processes rendezvous requests with bounded concurrency to apply backpressure (helping PoW effort ramp under load); this is wired through ASB config as a new tor.max_concurrent_rend_requests option (default 16) and documented.

Operationally, the ASB Docker build enables release debug symbols (CARGO_PROFILE_RELEASE_DEBUG=1), and the orchestrator’s compose adds SYS_PTRACE capability for the asb container; Cargo.lock is refreshed with multiple dependency bumps and a few new transitive crates.

Written by Cursor Bugbot for commit 1c6790e. This will update automatically on new commits. Configure here.

@binarybaron binarybaron force-pushed the feat/asb-conn-limit-new branch from 87d596e to 1c6790e Compare March 30, 2026 13:36
@binarybaron
Copy link
Copy Markdown
Author

bugobt run

@binarybaron
Copy link
Copy Markdown
Author

bugbot run

Copy link
Copy Markdown

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 2 potential issues.

Fix All in Cursor

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

@binarybaron binarybaron marked this pull request as ready for review March 30, 2026 14:18
@binarybaron binarybaron merged commit 9130934 into master Mar 30, 2026
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant