Merged
Conversation
87d596e to
1c6790e
Compare
Author
|
bugobt run |
Author
|
bugbot run |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Note
Medium Risk
Touches core P2P/Tor connection handling and introduces new connection limiting behavior, which can affect reachability and load characteristics if mis-tuned.
Overview
Hardens ASB networking against resource-exhaustion/DoS. It adds libp2p
connection_limitsto cap pending/established inbound connections and per-peer connections, and improves logging when inbound connections are denied due to limits.On the Tor onion-service path,
add_onion_servicenow accepts amax_concurrent_rend_requestsparameter and processes rendezvous requests with bounded concurrency to apply backpressure (helping PoW effort ramp under load); this is wired through ASB config as a newtor.max_concurrent_rend_requestsoption (default16) and documented.Operationally, the ASB Docker build enables release debug symbols (
CARGO_PROFILE_RELEASE_DEBUG=1), and the orchestrator’s compose addsSYS_PTRACEcapability for theasbcontainer;Cargo.lockis refreshed with multiple dependency bumps and a few new transitive crates.Written by Cursor Bugbot for commit 1c6790e. This will update automatically on new commits. Configure here.