feat(asb): buffer quote construction#922
Merged
binarybaron merged 3 commits intomasterfrom Mar 25, 2026
Merged
Conversation
Author
|
bugbot run |
Author
|
@Einliterflasche Please review. |
Author
|
bugbot run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Medium Risk
Changes the quote request/response flow in the ASB event loop by batching concurrent quote requests behind a single in-flight computation, which could affect responsiveness and failure behavior under load if the queue grows or the computation stalls.
Overview
Buffers and coalesces quote responses:
OutEvent::QuoteRequestedno longer computes/sends a quote per request; it now queues response channels and triggers at most one in-flight quote computation, replying to all pending requests when it resolves (falling back toBidQuote::ZEROon error).Refactors
make_quote_or_use_cachedto return a'staticboxed future (cloning needed dependencies) so quote computation can be stored/polled asynchronously in thetokio::select!loop without blocking other event processing.Written by Cursor Bugbot for commit 3e2b839. This will update automatically on new commits. Configure here.