Skip to content

feat(asb): buffer quote construction#922

Merged
binarybaron merged 3 commits intomasterfrom
fix/asb/buffer-quote-construction
Mar 25, 2026
Merged

feat(asb): buffer quote construction#922
binarybaron merged 3 commits intomasterfrom
fix/asb/buffer-quote-construction

Conversation

@binarybaron
Copy link
Copy Markdown

@binarybaron binarybaron commented Mar 25, 2026

Note

Medium Risk
Changes the quote request/response flow in the ASB event loop by batching concurrent quote requests behind a single in-flight computation, which could affect responsiveness and failure behavior under load if the queue grows or the computation stalls.

Overview
Buffers and coalesces quote responses: OutEvent::QuoteRequested no longer computes/sends a quote per request; it now queues response channels and triggers at most one in-flight quote computation, replying to all pending requests when it resolves (falling back to BidQuote::ZERO on error).

Refactors make_quote_or_use_cached to return a 'static boxed future (cloning needed dependencies) so quote computation can be stored/polled asynchronously in the tokio::select! loop without blocking other event processing.

Written by Cursor Bugbot for commit 3e2b839. This will update automatically on new commits. Configure here.

@binarybaron
Copy link
Copy Markdown
Author

bugbot run

@binarybaron
Copy link
Copy Markdown
Author

@Einliterflasche Please review.

Copy link
Copy Markdown

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

@binarybaron
Copy link
Copy Markdown
Author

bugbot run

@binarybaron binarybaron marked this pull request as ready for review March 25, 2026 12:58
@binarybaron binarybaron merged commit 6572675 into master Mar 25, 2026
33 of 34 checks passed
Copy link
Copy Markdown

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant