removed by MrCyjaneK · Pull Request #460 · eigenwallet/core

MrCyjaneK · 2025-07-15T16:41:27Z

removed

coderabbitai · 2025-07-15T16:41:33Z

Walkthrough

This set of changes updates build scripts, configuration files, dependencies, documentation, and submodules across the project. Key modifications include improved cross-platform build handling for Monero (notably for Windows and Apple targets), expanded and clarified documentation, refined formatting and submodule exclusions, updates to Tauri and related dependencies, enhanced error handling, and platform-specific configuration adjustments for desktop and mobile environments.

Changes

Cohort / File(s)	Change Summary
Monero Build System & Patches `.cargo/config.toml`, `monero-sys/build.rs`, `monero-sys/Cargo.toml`, `monero-sys/patches/*`	Refined Windows build config for MSVC/GNU, integrated multiple embedded patches, improved patch application logic, target-aware build steps, and updated dependencies for Monero C++ bridge.
Monero Submodules `.gitmodules`, `monero-sys/monero`, `monero-sys/monero_c`	Updated Monero submodule URLs/branches, added new submodule `monero_c`, and updated submodule commit references.
Documentation `monero-sys/CLAUDE.md`	Expanded and clarified documentation on Rust-to-C++ bridge, memory safety, and concurrency guarantees.
Formatting & Cleaning `dprint.json`, `justfile`	Updated directories excluded from formatting, and renamed/expanded the clean recipe to remove both Monero submodules and perform `cargo clean`.
Tauri & Desktop/Mobile Platform Config `src-tauri/tauri.conf.json`, `src-tauri/Cargo.toml`, `src-tauri/capabilities/default.json`, `src-tauri/capabilities/desktop.json`, `src-tauri/src/lib.rs`	Added platform-specific bundle config for macOS, iOS, and Windows; updated Tauri dependencies to wildcard versions; adjusted CLI permissions; and made window title logic conditional on desktop builds.
Build Tooling & Cross-Compilation `Cargo.toml`, `rust-toolchain.toml`, `.github/actions/set-monero-env/action.yml`	Added patch for `crunchy` crate to fix cross-compilation, switched Rust toolchain to nightly, and included `gperf` in Monero Linux dependencies.
Swap Build Process `swap/Cargo.toml`, `swap/build.rs`	Switched from `vergen` to `vergen-git2` for build metadata, updating both dependency and build script logic.
Frontend Error Handling `src-gui/src/store/config.ts`	Added error handling for CLI matches retrieval to ensure robust initialization.

Sequence Diagram(s)

sequenceDiagram
    participant BuildScript as build.rs
    participant Depends as contrib/depends
    participant CMake as CMake
    participant Patch as Embedded Patch
    participant Make as make
    participant Output as Build Output

    BuildScript->>Patch: Apply embedded patches (skip if already applied)
    BuildScript->>Depends: Copy depends if not present
    BuildScript->>Make: Run make with normalized target
    Make-->>BuildScript: Stream stdout/stderr in real time
    BuildScript->>CMake: Configure with toolchain and paths
    CMake->>Output: Build native libraries
    BuildScript->>Output: Add link/search paths, set env vars

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~45 minutes

Poem

In the garden of code where the Monero vines grow,
New patches and scripts let the cross-compilers flow.
Submodules now pruned, dependencies in line,
Tauri and swap with their versions refined.
The rabbit hops on—nightly Rust in its paws—
Cheering safe bridges and builds without flaws!
🐇✨

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c4de9eb and ee325e1.

⛔ Files ignored due to path filters (5)

Cargo.lock is excluded by !**/*.lock
src-tauri/gen/apple/LaunchScreen.storyboard is excluded by !**/gen/**
src-tauri/gen/apple/project.yml is excluded by !**/gen/**
src-tauri/gen/apple/unstoppableswap-gui-rs.xcodeproj/project.pbxproj is excluded by !**/gen/**
src-tauri/gen/apple/unstoppableswap-gui-rs.xcodeproj/xcshareddata/xcschemes/unstoppableswap-gui-rs_iOS.xcscheme is excluded by !**/gen/**

📒 Files selected for processing (11)

Cargo.toml (1 hunks)
justfile (1 hunks)
monero-sys/Cargo.toml (1 hunks)
monero-sys/build.rs (12 hunks)
rust-toolchain.toml (1 hunks)
src-gui/src/store/config.ts (1 hunks)
src-tauri/Cargo.toml (2 hunks)
src-tauri/capabilities/default.json (0 hunks)
src-tauri/src/lib.rs (1 hunks)
src-tauri/tauri.conf.json (1 hunks)
swap/Cargo.toml (1 hunks)

💤 Files with no reviewable changes (1)

src-tauri/capabilities/default.json

🚧 Files skipped from review as they are similar to previous changes (7)

monero-sys/Cargo.toml
Cargo.toml
swap/Cargo.toml
src-tauri/src/lib.rs
src-tauri/tauri.conf.json
justfile
src-tauri/Cargo.toml

🧰 Additional context used

📓 Path-based instructions (1)

monero-sys/**/build.rs

📄 CodeRabbit Inference Engine (monero-sys/CLAUDE.md)

In build.rs, compile the Monero C++ code with CMake targeting wallet_api, set up include paths and library linking, configure CXX to build the bridge, and link required static and dynamic libraries.

Files:

monero-sys/build.rs

🧠 Learnings (3)

📓 Common learnings

Learnt from: CR
PR: eigenwallet/core#0
File: AGENT.md:0-0
Timestamp: 2025-07-23T20:01:42.422Z
Learning: Applies to swap/Cargo.toml : The `swap/Cargo.toml` file is frequently edited and should be reviewed carefully for dependency and configuration changes

Learnt from: CR
PR: eigenwallet/core#0
File: monero-sys/CLAUDE.md:0-0
Timestamp: 2025-07-23T20:01:33.031Z
Learning: Applies to monero-sys/**/build.rs : In build.rs, compile the Monero C++ code with CMake targeting wallet_api, set up include paths and library linking, configure CXX to build the bridge, and link required static and dynamic libraries.

Learnt from: CR
PR: eigenwallet/core#0
File: AGENT.md:0-0
Timestamp: 2025-07-23T20:01:42.422Z
Learning: Applies to src-tauri/Cargo.toml : The `src-tauri/Cargo.toml` file is frequently edited and should be reviewed carefully for dependency and configuration changes

Learnt from: CR
PR: eigenwallet/core#0
File: AGENT.md:0-0
Timestamp: 2025-07-23T20:01:42.422Z
Learning: Applies to src-tauri/tauri.conf.json : The `src-tauri/tauri.conf.json` file is frequently edited and should be reviewed for correct Tauri configuration

rust-toolchain.toml (4)

Learnt from: CR
PR: eigenwallet/core#0
File: AGENT.md:0-0
Timestamp: 2025-07-23T20:01:42.422Z
Learning: Applies to src-tauri/Cargo.toml : The src-tauri/Cargo.toml file is frequently edited and should be reviewed carefully for dependency and configuration changes

Learnt from: CR
PR: eigenwallet/core#0
File: AGENT.md:0-0
Timestamp: 2025-07-23T20:01:42.422Z
Learning: Applies to swap/Cargo.toml : The swap/Cargo.toml file is frequently edited and should be reviewed carefully for dependency and configuration changes

Learnt from: CR
PR: eigenwallet/core#0
File: monero-sys/CLAUDE.md:0-0
Timestamp: 2025-07-23T20:01:33.031Z
Learning: Use Rust 2021 edition.

Learnt from: CR
PR: eigenwallet/core#0
File: AGENT.md:0-0
Timestamp: 2025-07-23T20:01:42.422Z
Learning: Applies to Cargo.lock : The Cargo.lock file is frequently edited and should be reviewed carefully for dependency lock changes

monero-sys/build.rs (16)

Learnt from: CR
PR: eigenwallet/core#0
File: monero-sys/CLAUDE.md:0-0
Timestamp: 2025-07-23T20:01:33.031Z
Learning: Applies to monero-sys/**/build.rs : In build.rs, compile the Monero C++ code with CMake targeting wallet_api, set up include paths and library linking, configure CXX to build the bridge, and link required static and dynamic libraries.

Learnt from: CR
PR: eigenwallet/core#0
File: monero-sys/CLAUDE.md:0-0
Timestamp: 2025-07-23T20:01:33.031Z
Learning: Applies to monero-sys/src/{bridge.rs,lib.rs} : In src/bridge.rs, when adding a new function to the bridge, copy its definition from monero/src/wallet/api/wallet2_api.h into bridge.rs, and add wrapping logic in src/lib.rs.

Learnt from: CR
PR: eigenwallet/core#0
File: monero-sys/CLAUDE.md:0-0
Timestamp: 2025-07-23T20:01:33.031Z
Learning: Applies to monero-sys/src/bridge.rs : In src/bridge.rs, use the cxx::bridge macro to define the FFI interface, declare C++ types and functions, and wrap static C++ methods as free functions.

Learnt from: CR
PR: eigenwallet/core#0
File: monero-sys/CLAUDE.md:0-0
Timestamp: 2025-07-23T20:01:33.031Z
Learning: Applies to monero-sys/src/lib.rs : In src/lib.rs, provide idiomatic Rust interfaces to the C++ code, use wrapper types (WalletManager, Wallet) with safer interfaces, and handle memory management and safety concerns (never expose raw pointers, implement Send and Sync, use Pin for C++ objects requiring stable memory addresses).

Learnt from: CR
PR: eigenwallet/core#0
File: monero-sys/CLAUDE.md:0-0
Timestamp: 2025-07-23T20:01:33.031Z
Learning: Applies to monero-sys/src/{bridge.rs,lib.rs} : Use unsafe only for FFI interactions with Monero C++ code.

Learnt from: CR
PR: eigenwallet/core#0
File: monero-sys/CLAUDE.md:0-0
Timestamp: 2025-07-23T20:01:33.031Z
Learning: Applies to monero-sys/src/bridge.h : In bridge.h, provide helper functions to work around CXX limitations, including wrappers for static methods and handling string returns with std::unique_ptrstd::string.

Learnt from: CR
PR: eigenwallet/core#0
File: monero-sys/CLAUDE.md:0-0
Timestamp: 2025-07-23T20:01:33.031Z
Learning: Applies to monero-sys/src/{bridge.rs,lib.rs} : Raw pointers must be wrapped in safe Rust types, and unsafe is only used at the FFI boundary.

Learnt from: CR
PR: eigenwallet/core#0
File: monero-sys/CLAUDE.md:0-0
Timestamp: 2025-07-23T20:01:33.031Z
Learning: When adding new functionality: 1. Find the function in wallet2_api.h, 2. Add its declaration to the unsafe extern "C++" block in bridge.rs, 3. Create a corresponding Rust wrapper in lib.rs, 4. For functions returning strings or with CXX limitations, add helper functions in bridge.h.

Learnt from: CR
PR: eigenwallet/core#0
File: monero-sys/CLAUDE.md:0-0
Timestamp: 2025-07-23T20:01:33.031Z
Learning: When implementing new wrapper functions: 1. Locate the function in wallet2_api.h, 2. Copy the exact method signature to bridge.rs, 3. Implement the Rust wrapper in lib.rs, 4. Run the build to ensure everything compiles.

Learnt from: CR
PR: eigenwallet/core#0
File: monero-sys/CLAUDE.md:0-0
Timestamp: 2025-07-23T20:01:33.031Z
Learning: Applies to monero-sys/src/lib.rs : Implement proper deref for wrapper types and use the OnceLock pattern to ensure WalletManager is a singleton.

Learnt from: CR
PR: eigenwallet/core#0
File: monero-sys/CLAUDE.md:0-0
Timestamp: 2025-07-23T20:01:33.031Z
Learning: Always verify method signatures in the Monero C++ headers before adding them to the Rust bridge.

Learnt from: CR
PR: eigenwallet/core#0
File: AGENT.md:0-0
Timestamp: 2025-07-23T20:01:42.422Z
Learning: Applies to swap/Cargo.toml : The swap/Cargo.toml file is frequently edited and should be reviewed carefully for dependency and configuration changes

Learnt from: CR
PR: eigenwallet/core#0
File: AGENT.md:0-0
Timestamp: 2025-07-23T20:01:42.422Z
Learning: Applies to src-tauri/Cargo.toml : The src-tauri/Cargo.toml file is frequently edited and should be reviewed carefully for dependency and configuration changes

Learnt from: CR
PR: eigenwallet/core#0
File: monero-sys/CLAUDE.md:0-0
Timestamp: 2025-07-23T20:01:33.031Z
Learning: Applies to monero-sys/src/**/*.rs : When using .expect(), the message should be a short description of the assumed invariant in the format of .expect("the invariant to be upheld").

Learnt from: CR
PR: eigenwallet/core#0
File: AGENT.md:0-0
Timestamp: 2025-07-23T20:01:42.422Z
Learning: Applies to Cargo.lock : The Cargo.lock file is frequently edited and should be reviewed carefully for dependency lock changes

Learnt from: CR
PR: eigenwallet/core#0
File: monero-sys/CLAUDE.md:0-0
Timestamp: 2025-07-23T20:01:33.031Z
Learning: Use Rust 2021 edition.

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

GitHub Check: Cursor Bugbot

🔇 Additional comments (10)

src-gui/src/store/config.ts (3)

3-3: LGTM: Improved type safety.

Adding the CliMatches type import enhances TypeScript type safety and provides better IDE support for the CLI matches handling.

6-6: LGTM: Proper variable typing.

The explicit CliMatches typing provides compile-time type safety and is consistent with the updated import.

7-13: Excellent error handling implementation.

The try-catch block with a sensible fallback ensures the application remains robust even if CLI matches retrieval fails. The fallback object structure { args: {} } is perfectly compatible with the existing code that uses optional chaining (matches.args.testnet?.value), preventing runtime errors while maintaining expected functionality.

monero-sys/build.rs (6)

31-55: LGTM! Well-structured embedded patches addressing build issues.

The expansion of embedded patches from 1 to 6 is well-organized and addresses specific cross-platform build issues mentioned in the PR objectives. Each patch follows the established pattern and has descriptive names and descriptions.

140-162: Excellent target normalization implementation.

The target normalization using a match statement is clean and maintainable. The whitelist validation ensures build failures happen early for unsupported targets rather than during the build process.

164-192: Well-implemented make command execution with proper isolation.

The environment isolation for Apple targets and real-time output streaming significantly improve the build process. The error handling properly catches and reports build failures.

197-249: Proper CMake integration with contrib/depends system.

The CMake configuration correctly uses the contrib/depends toolchain file and sets up library search paths. The explicit Sodium configuration ensures cross-platform compatibility.

351-475: Excellent platform-specific configuration improvements.

The separation of macOS and iOS configurations, addition of iOS minimum version requirements, and Windows static linking properly address the cross-platform build issues mentioned in the PR objectives. The CXX bridge integration with contrib/depends maintains consistency.

573-583: Smart improvement to patch application logic.

The reverse patch check makes patch application idempotent, preventing re-application errors on incremental builds. This significantly improves build reliability.

rust-toolchain.toml (1)

3-3: Verify necessity of nightly toolchain and update documentation.

Switching from stable "1.85" to "nightly" is a significant change that affects build stability and compatibility.

Please confirm:

Is the nightly toolchain required for specific features used in the build process?

The comment on line 2 mentions updating readme, changelog, and GitHub actions - have these been updated?

Consider the stability implications of using nightly in production builds.

✨ Finishing Touches

📝 Generate Docstrings

🧪 Generate unit tests

Create PR with unit tests
Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai generate unit tests to generate unit tests for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

binarybaron · 2025-07-15T16:42:42Z

Cool! I'll try it out in a minute.

coderabbitai

Actionable comments posted: 2

🔭 Outside diff range comments (3)

monero-sys/build.rs (3)

51-51: Fix typo in comment

"Eerun" should be "Rerun".

-    // Eerun this when the bridge.rs or static_bridge.h file changes.
+    // Rerun this when the bridge.rs or static_bridge.h file changes.

201-201: Remove or conditionalize hardcoded library path

The hardcoded path /usr/lib/x86_64-linux-gnu is not portable and will cause issues on non-x86_64 or non-Linux systems.

Consider either:

Making this conditional based on the target:

-    println!("cargo:rustc-link-search=native=/usr/lib/x86_64-linux-gnu");
+    #[cfg(all(target_os = "linux", target_arch = "x86_64"))]
+    println!("cargo:rustc-link-search=native=/usr/lib/x86_64-linux-gnu");

Or removing it if the contrib/depends system provides all necessary libraries.

268-271: Fix println! macro syntax

Remove the spaces between println and ! to fix the syntax error.

-        println !("cargo:rustc-link-search=native=/Library/Developer/CommandLineTools/usr/lib/clang/15.0.0/lib/darwin");
-        println !("cargo:rustc-link-search=native=/Library/Developer/CommandLineTools/usr/lib/clang/16.0.0/lib/darwin");
-        println !("cargo:rustc-link-search=native=/Library/Developer/CommandLineTools/usr/lib/clang/17.0.0/lib/darwin");
-        println !("cargo:rustc-link-search=native=/Library/Developer/CommandLineTools/usr/lib/clang/18.0.0/lib/darwin");
+        println!("cargo:rustc-link-search=native=/Library/Developer/CommandLineTools/usr/lib/clang/15.0.0/lib/darwin");
+        println!("cargo:rustc-link-search=native=/Library/Developer/CommandLineTools/usr/lib/clang/16.0.0/lib/darwin");
+        println!("cargo:rustc-link-search=native=/Library/Developer/CommandLineTools/usr/lib/clang/17.0.0/lib/darwin");
+        println!("cargo:rustc-link-search=native=/Library/Developer/CommandLineTools/usr/lib/clang/18.0.0/lib/darwin");

🧹 Nitpick comments (3)

swap/Cargo.toml (1)
110-110: Consider a more specific version constraint for stability.

The migration from vergen to vergen-git2 looks good and aligns with the API changes in build.rs. However, the version constraint "1" is quite broad and might allow breaking changes in patch versions.

Consider using a more specific version constraint like "1.0" or "1.0.0" for better build reproducibility.
-vergen-git2 = { version = "1", features = ["build"] }
+vergen-git2 = { version = "1.0", features = ["build"] }
monero-sys/monero_c (1)

1-1: Pin submodule to a stable, tagged Monero-C revision for reproducible builds

The pointer currently references an arbitrary commit on develop. Relying on an untagged commit can silently pull in breaking changes when the submodule is updated in the future. Consider updating .gitmodules to follow a release tag (or vendor the exact commit with a locked SHA in CI) to guarantee deterministic builds across environments.

monero-sys/build.rs (1)

109-109: Remove trailing whitespace from empty lines

Empty lines should not contain whitespace characters.

Also applies to: 132-132

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ccce33f and 264e4a3.

⛔ Files ignored due to path filters (1)

Cargo.lock is excluded by !**/*.lock

📒 Files selected for processing (10)

.cargo/config.toml (1 hunks)
.gitmodules (1 hunks)
monero-sys/build.rs (5 hunks)
monero-sys/monero (1 hunks)
monero-sys/monero_c (1 hunks)
monero-sys/patches/0001-fix-dummy-translation-generator.patch (1 hunks)
monero-sys/patches/0002-fix-iOS-depends-build.patch (1 hunks)
monero-sys/patches/0003-include-locale-only-when-targeting-WIN32.patch (1 hunks)
swap/Cargo.toml (1 hunks)
swap/build.rs (1 hunks)

🧰 Additional context used

📓 Path-based instructions (2)

monero-sys/**/*.rs

Instructions used from:

Sources:
📄 CodeRabbit Inference Engine

monero-sys/CLAUDE.md

monero-sys/**/build.rs

Instructions used from:

Sources:
📄 CodeRabbit Inference Engine

monero-sys/CLAUDE.md

🧠 Learnings (11)

📓 Common learnings

Learnt from: CR
PR: UnstoppableSwap/core#0
File: monero-sys/CLAUDE.md:0-0
Timestamp: 2025-06-30T08:53:46.750Z
Learning: Applies to monero-sys/**/build.rs : In build.rs, compile the Monero C++ code with CMake targeting wallet_api, set up include paths and library linking, configure CXX, and link required libraries.

Learnt from: CR
PR: UnstoppableSwap/core#0
File: monero-sys/CLAUDE.md:0-0
Timestamp: 2025-06-30T08:53:46.750Z
Learning: Applies to monero-sys/**/*.rs : Use Rust 2021 edition.

Learnt from: CR
PR: UnstoppableSwap/core#0
File: AGENT.md:0-0
Timestamp: 2025-06-30T08:53:49.176Z
Learning: Pull request titles must use the format `<type>(<scope>): <description>`, for example: `feat(gui): New feature`, `fix(swap): Issue fixed`, or `refactor(ci): Ci changes`.

Learnt from: CR
PR: UnstoppableSwap/core#0
File: monero-sys/CLAUDE.md:0-0
Timestamp: 2025-06-30T08:53:46.750Z
Learning: Applies to monero-sys/src/lib.rs : In src/lib.rs, provide idiomatic Rust interfaces to the C++ code, using wrapper types (WalletManager, Wallet) with safer interfaces, and handle memory management and safety concerns.

Learnt from: CR
PR: UnstoppableSwap/core#0
File: monero-sys/CLAUDE.md:0-0
Timestamp: 2025-06-30T08:53:46.750Z
Learning: Applies to monero-sys/**/bridge.h : In bridge.h, provide helper functions to work around CXX limitations, including wrappers for static methods and handling string returns with std::unique_ptr.

Learnt from: CR
PR: UnstoppableSwap/core#0
File: monero-sys/CLAUDE.md:0-0
Timestamp: 2025-06-30T08:53:46.750Z
Learning: Applies to monero-sys/src/lib.rs : Implement proper deref for wrapper types in src/lib.rs.

monero-sys/monero_c (10)

undefined

<retrieved_learning>
Learnt from: CR
PR: UnstoppableSwap/core#0
File: monero-sys/CLAUDE.md:0-0
Timestamp: 2025-06-30T08:53:46.750Z
Learning: Applies to monero-sys/**/*.rs : Use unsafe only for FFI interactions with Monero C++ code.
</retrieved_learning>

<retrieved_learning>
Learnt from: CR
PR: UnstoppableSwap/core#0
File: monero-sys/CLAUDE.md:0-0
Timestamp: 2025-06-30T08:53:46.750Z
Learning: Applies to monero-sys/src/bridge.rs : In src/bridge.rs, mirror functions from monero/src/wallet/api/wallet2_api.h by copying their definitions and letting CXX generate the bindings.
</retrieved_learning>

<retrieved_learning>
Learnt from: CR
PR: UnstoppableSwap/core#0
File: monero-sys/CLAUDE.md:0-0
Timestamp: 2025-06-30T08:53:46.750Z
Learning: Applies to monero-sys/**/build.rs : In build.rs, compile the Monero C++ code with CMake targeting wallet_api, set up include paths and library linking, configure CXX, and link required libraries.
</retrieved_learning>

<retrieved_learning>
Learnt from: CR
PR: UnstoppableSwap/core#0
File: monero-sys/CLAUDE.md:0-0
Timestamp: 2025-06-30T08:53:46.750Z
Learning: Applies to monero-sys/{src/bridge.rs,src/lib.rs} : When adding a new function to the bridge, copy its definition from monero/src/wallet/api/wallet2_api.h into bridge.rs, then add wrapping logic in src/lib.rs.
</retrieved_learning>

<retrieved_learning>
Learnt from: CR
PR: UnstoppableSwap/core#0
File: monero-sys/CLAUDE.md:0-0
Timestamp: 2025-06-30T08:53:46.750Z
Learning: Applies to monero-sys/src/lib.rs : Use Pin for C++ objects that require stable memory addresses in src/lib.rs.
</retrieved_learning>

<retrieved_learning>
Learnt from: CR
PR: UnstoppableSwap/core#0
File: monero-sys/CLAUDE.md:0-0
Timestamp: 2025-06-30T08:53:46.750Z
Learning: Applies to monero-sys/src/lib.rs : In src/lib.rs, provide idiomatic Rust interfaces to the C++ code, using wrapper types (WalletManager, Wallet) with safer interfaces, and handle memory management and safety concerns.
</retrieved_learning>

<retrieved_learning>
Learnt from: CR
PR: UnstoppableSwap/core#0
File: monero-sys/CLAUDE.md:0-0
Timestamp: 2025-06-30T08:53:46.750Z
Learning: Applies to monero-sys/src/bridge.rs : In src/bridge.rs, define the FFI interface using the cxx::bridge macro, declaring C++ types and functions to be accessed from Rust.
</retrieved_learning>

<retrieved_learning>
Learnt from: CR
PR: UnstoppableSwap/core#0
File: monero-sys/CLAUDE.md:0-0
Timestamp: 2025-06-30T08:53:46.750Z
Learning: Applies to monero-sys/**/*.rs : Use Rust 2021 edition.
</retrieved_learning>

<retrieved_learning>
Learnt from: CR
PR: UnstoppableSwap/core#0
File: monero-sys/CLAUDE.md:0-0
Timestamp: 2025-06-30T08:53:46.750Z
Learning: Applies to monero-sys/src/lib.rs : Raw pointers must never be exposed to users of the library in src/lib.rs.
</retrieved_learning>

<retrieved_learning>
Learnt from: CR
PR: UnstoppableSwap/core#0
File: monero-sys/CLAUDE.md:0-0
Timestamp: 2025-06-30T08:53:46.750Z
Learning: Applies to monero-sys/src/lib.rs : Implement proper deref for wrapper types in src/lib.rs.
</retrieved_learning>

swap/Cargo.toml (1)

Learnt from: CR
PR: UnstoppableSwap/core#0
File: monero-sys/CLAUDE.md:0-0
Timestamp: 2025-06-30T08:53:46.750Z
Learning: Applies to monero-sys/**/*.rs : Use Rust 2021 edition.

monero-sys/monero (10)