feat: monero-native integration (FFI C wrapper)#244
Closed
binarybaron wants to merge 3 commits intomasterfrom
Closed
feat: monero-native integration (FFI C wrapper)#244binarybaron wants to merge 3 commits intomasterfrom
binarybaron wants to merge 3 commits intomasterfrom
Conversation
e0a77b4 to
5cc7a0b
Compare
Author
|
@delta1 Hey Byron, I'm currently working on migrating from monero-wallet-rpc to native monero bindings. We use a wrapper called monero_c which is wrapped with FFI bindings (PR but the most up-to-date version is in our PR here. I'm not super familiar with C++ (especially the build systems and all that) and I'm struggling with getting it all running in a nice and reproducible way. If you have any pointers for me, or would like to contribute to getting that working on a reliable way, I'd be super thankful 🙏 |
…RO_Wallet_checkTxKey issue
Author
Author
|
Closing this in favour of #303 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #114
Motivation
Currently we are dependent on
monero-wallet-rpcwhich causes a few issues:monero-wallet-rpcprocess on exit #21)monero-wallet-rpcon startup which introduces complexityWe want to replace this with native bindings. We use the Rust FFI bindings to
monero_c. @sneurlax is working on in this PRwallet2.hwhich is the backbone for monero_cTODO, in no specific order
monero-wallet-rpcin the code with references to themonero_crust bindingsMONERO_Wallet_checkTxKey(See: Rust develop MrCyjaneK/monero_c#103 (comment))monero-wallet-rpcwith a feature flag. This could be useful for theasbor for our integration tests. However I'm leaning strongly towards removing support entirely.monero_cfor ourmonero-harnesscratemonero-rpccratewallet2in-and-out.unwrap()calls