feat: add new module scan mode

core/common-util/src/ModuleConfig.ts

@@ -124,6 +124,38 @@ export class ModuleConfigUtil {
         path: moduleDir,
       });
     }
+    const moduleReferences = this.readModuleFromNodeModules(baseDir);
+    for (const moduleReference of moduleReferences) {
+      const moduleBasePath = path.basename(moduleReference.path);
+      moduleDirSet.forEach(modulePath => {
+        if (path.basename(modulePath) === moduleBasePath) {
+          throw new Error('duplicate import of module reference: ' + moduleBasePath);
+        }
+      });
+      ref.push({
+        path: moduleReference.path,
+      });
+    }
+    return ref;
+  }
+
+  private static readModuleFromNodeModules(baseDir: string) {
+    const ref: ModuleReference[] = [];
+    const pkgContent = fs.readFileSync(path.join(baseDir, 'package.json'), 'utf8');
+    const pkg = JSON.parse(pkgContent);
+    for (const dependencyKey of Object.keys(pkg.dependencies || {})) {
+      const absolutePkgPath = path.join(baseDir, '/node_modules', dependencyKey);
+      const realPkgPath = fs.realpathSync(absolutePkgPath);
+      try {
+        if (this.readModuleNameSync(realPkgPath)) {
+          ref.push({
+            path: realPkgPath,
+          });
+        }
+      } catch (_) {
+        continue;
+      }
+    }
     return ref;
   }
 

core/common-util/test/ModuleConfig.test.ts

@@ -19,9 +19,15 @@ describe('test/ModuleConfig.test.ts', () => {
           { path: path.join(fixturesPath, 'app/module-a') },
           { path: path.join(fixturesPath, 'app/module-b') },
           { path: path.join(fixturesPath, 'app/module-b/test/fixtures/module-e') },
+          { path: path.join(fixturesPath, 'node_modules/module-c') },
         ]);
       });
 
+      it('duplicated module', () => {
+        const fixturesPath = path.join(__dirname, './fixtures/apps/app-with-no-module-json-duplicated');
+        assert.throws(() => { ModuleConfigUtil.readModuleReference(fixturesPath); }, /duplicate import of module reference/, 'did not throw with expected message');
+      });
+
       describe('has symlink', () => {
         it('should work', () => {
           const fixturesPath = path.join(__dirname, './fixtures/apps/app-with-symlink');

core/common-util/test/fixtures/apps/app-with-no-module-json-duplicated/.sff/.other/module-d/package.json

@@ -0,0 +1,6 @@
+{
+  "name": "module-d",
+  "eggModule": {
+    "name": "moduleD"
+  }
+}

core/common-util/test/fixtures/apps/app-with-no-module-json-duplicated/.sff/module-c/package.json

@@ -0,0 +1,6 @@
+{
+  "name": "module-c",
+  "eggModule": {
+    "name": "moduleC"
+  }
+}

core/common-util/test/fixtures/apps/app-with-no-module-json-duplicated/app/module-a/package.json

@@ -0,0 +1,6 @@
+{
+  "name": "module-a",
+  "eggModule": {
+    "name": "moduleA"
+  }
+}

core/common-util/test/fixtures/apps/app-with-no-module-json-duplicated/app/module-b/package.json

@@ -0,0 +1,6 @@
+{
+  "name": "module-b",
+  "eggModule": {
+    "name": "moduleB"
+  }
+}

core/common-util/test/fixtures/apps/app-with-no-module-json-duplicated/app/module-b/test/fixtures/module-e/package.json

@@ -0,0 +1,6 @@
+{
+  "name": "module-e",
+  "eggModule": {
+    "name": "moduleE"
+  }
+}

core/common-util/test/fixtures/apps/app-with-no-module-json-duplicated/package.json

@@ -0,0 +1,6 @@
+{
+  "name": "foo",
+  "dependencies": {
+    "module-b": "^1.0.0"
+  }
+}

core/common-util/test/fixtures/apps/app-with-no-module-json/package.json

@@ -1,3 +1,7 @@
 {
-  "name": "foo"
+  "name": "foo",
+  "dependencies": {
+    "module-c": "^1.0.0",
+    "dep": "^1.0.0"
+  }
 }