Skip to content

fix: mcp version check #311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
akitaSummer merged 2 commits into from
May 1, 2025
Merged

fix: mcp version check #311

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8e74716
fix: mcp version check
akitaSummer Apr 30, 2025
4325e39
fix: proxy ctx
akitaSummer May 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions plugin/controller/app.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ import { MCPControllerRegister } from './lib/impl/mcp/MCPControllerRegister';
// 1. await add load unit is ready, controller may depend other load unit
// 2. load ${app_base_dir}app/controller file
// 3. ControllerRegister register controller implement
const majorVersion = parseInt(process.versions.node.split('.')[0], 10);

export default class ControllerAppBootHook {
private readonly app: Application;
Expand Down Expand Up @@ -62,7 +63,7 @@ export default class ControllerAppBootHook {

// init http root proto middleware
this.prepareMiddleware(this.app.config.coreMiddleware);
if (this.app.mcpProxy) {
if (majorVersion >= 18) {
this.controllerRegisterFactory.registerControllerRegister(ControllerType.MCP, MCPControllerRegister.create);
// Don't let the mcp's body be consumed
this.app.config.coreMiddleware.unshift('mcpBodyMiddleware');
Expand Down Expand Up @@ -113,7 +114,7 @@ export default class ControllerAppBootHook {
}

async willReady() {
if (this.app.mcpProxy) {
if (majorVersion >= 18) {
await MCPControllerRegister.connectStatelessStreamTransport();
}
}
Expand Down
9 changes: 8 additions & 1 deletion plugin/mcp-proxy/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,9 +59,16 @@ export const MCPProxyHook: MCPControllerHook = {
await self.app.mcpProxy.registerClient(id, process.pid);
self.app.mcpProxy.setProxyHandler(MCPProtocols.SSE, async (req, res) => {
const sessionId = req.query?.sessionId ?? querystring.parse(url.parse(req.url).query ?? '').sessionId as string;
// eslint-disable-next-line @typescript-eslint/ban-ts-comment
// @ts-ignore
self.app.RequestClass = EggRequest;
// eslint-disable-next-line @typescript-eslint/ban-ts-comment
// @ts-ignore
self.app.ResponseClass = EggResponse;
const ctx = new EggContext(self.app as any, req, res) as any;
if (MCPControllerRegister.hooks.length > 0) {
for (const hook of MCPControllerRegister.hooks) {
await hook.preProxy?.(self.app.currentContext, req, res);
await hook.preProxy?.(ctx, req, res);
}
}
let transport: SSEServerTransport;
Expand Down
Loading