Skip to content

feat: add new module scan mode#58

Merged
killagu merged 2 commits intoeggjs:masterfrom
412799755:add-new-module-scan-mode
Nov 23, 2022
Merged

feat: add new module scan mode#58
killagu merged 2 commits intoeggjs:masterfrom
412799755:add-new-module-scan-mode

Conversation

@412799755
Copy link
Contributor

@412799755 412799755 commented Nov 15, 2022

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

@codecov
Copy link

codecov bot commented Nov 15, 2022

Codecov Report

Base: 92.12% // Head: 92.16% // Increases project coverage by +0.03% 🎉

Coverage data is based on head (880028c) compared to base (de1a917).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #58      +/-   ##
==========================================
+ Coverage   92.12%   92.16%   +0.03%     
==========================================
  Files         215      215              
  Lines        4282     4301      +19     
  Branches      410      413       +3     
==========================================
+ Hits         3945     3964      +19     
  Misses        336      336              
  Partials        1        1              
Impacted Files Coverage Δ
core/common-util/src/ModuleConfig.ts 74.43% <100.00%> (+4.26%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@killagu killagu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@killagu killagu merged commit 3be6c20 into eggjs:master Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants