Enhance RealtimeIrl by adding the missing metrics #189
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eerimoq
reviewed
Dec 2, 2025
eerimoq
reviewed
Dec 2, 2025
| } else { | ||
| pedometerStepsDevice = steps | ||
| } | ||
| } |
Owner
There was a problem hiding this comment.
Why does this class have to know about the source (watch or device) of the measurement? Not needed imo.
Author
There was a problem hiding this comment.
Because we should prefer using watch as it should be more precise I think
Owner
There was a problem hiding this comment.
if we are lucky the watch work at all =) I probably didn't officially added to to text widget because it didn't work, but maybe..
either way, logic like this should not be part of this class, but some other class that can be used by the text widget as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the missing metrics to RealtimeIrl (heading, steps, heart rate, cycling power, cycling crank and cycling wheel rpm.
It prefers metrics from Apple Watch if they are available otherwise it uses the metrics available from device.
Unable to compile or test, so feel free to suggest any changes.