Skip to content

Added support for the NO_PROXY env variable#361

Merged
edgurgel merged 3 commits into
edgurgel:masterfrom
ShahneRodgers:no_proxy_env_support
Nov 14, 2018
Merged

Added support for the NO_PROXY env variable#361
edgurgel merged 3 commits into
edgurgel:masterfrom
ShahneRodgers:no_proxy_env_support

Conversation

@ShahneRodgers
Copy link
Copy Markdown
Contributor

This commit adds support for the NO_PROXY (or no_PROXY / no_proxy) environment variable in a GNU-supported format to fix #331.

This commit adds support for the NO_PROXY (or no_PROXY / no_proxy) environment variable in a GNU-supported format (https://www.gnu.org/software/emacs/manual/html_node/url/Proxies.html) to fix edgurgel#331.
…thod.

Hopefully this makes the tests a little easier to understand.
@edgurgel
Copy link
Copy Markdown
Owner

Hey thanks for the PR ! I will review as soon as possible 👍

@mkreyman
Copy link
Copy Markdown

When would this get merged? Introduction of HTTP_PROXY in version "1.1.0" without corresponding NO_PROXY/no_proxy variable(s) brakes one of our dependencies, while capping httpoison at "1.0.0" breaks some other...

@edgurgel edgurgel merged commit f31f580 into edgurgel:master Nov 14, 2018
@edgurgel
Copy link
Copy Markdown
Owner

amazing work, @ShahneRodgers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

NO_PROXY env variable is not respected

3 participants