Consider Cloudflare challenges to be bad captures #44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We hit a lot of Cloudflare challenges on ehp.niehs.nih.gov last month that caused problems and hit them occasionally on other sites. Like AWS WAF challenges, these are not really good/valid/legitimate captures that should be considered as changed content. This adds heuristics for them to the `maybe_bad_capture()` method so we don’t use them in changes. For more on the Cloudflare challenges, see: - edgi-govdata-archiving/web-monitoring#189 - edgi-govdata-archiving/web-monitoring-crawler#32
Mr0grog
deleted the
cloudflare-challenges-are-not-the-webpages-you-are-looking-for
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We hit a lot of Cloudflare challenges on ehp.niehs.nih.gov last month that caused problems and hit them occasionally on other sites. Like AWS WAF challenges, these are not really good/valid/legitimate captures that should be considered as changed content. This adds heuristics for them to the
maybe_bad_capture()method so we don’t use them in changes.For more on the Cloudflare challenges, see: