Add some Spanish key terms (and handle accents better) #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should always have been doing this, but the problem is a lot more obvious when it comes to Spanish text. We at least need to choose a specific unicode normalization for comparisons (I've gone with NFKC, but NFKD could also work; I think it needs to be NFK-something, though). Additionally, I've gone ahead and simply removed accents altogether here, which I think is probably good for comparisons (obviously bad if we were ever going to display the resulting text).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I realized yesterday that we are probably not surfacing some important changes to Spanish pages (now that we are tracking a handful) because we don’t have a Spanish version of any of our key terms. This adds a few (we should probably just translate them all).
Doing so revealed that we were not necessarily handling accents very well or very reliably, so I’ve also added code to: