Skip to content

Conversation

@rsdmike
Copy link
Member

@rsdmike rsdmike commented Aug 22, 2019

closes #184

Signed-off-by: Mike Johanson [email protected]

Copy link
Member

@lenny-goodell lenny-goodell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-io
Copy link

codecov-io commented Aug 22, 2019

Codecov Report

Merging #185 into master will decrease coverage by 0.08%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #185      +/-   ##
==========================================
- Coverage   62.64%   62.56%   -0.09%     
==========================================
  Files          16       16              
  Lines         771      772       +1     
==========================================
  Hits          483      483              
- Misses        261      262       +1     
  Partials       27       27
Impacted Files Coverage Δ
appsdk/sdk.go 22.42% <0%> (-0.11%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90c0231...1502082. Read the comment docs.

@rsdmike rsdmike merged commit a21c223 into edgexfoundry:master Aug 23, 2019
@rsdmike rsdmike deleted the #184 branch August 23, 2019 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Service.Protocol in configuration.toml is not being used.

3 participants