Skip to content

Conversation

@rsdmike
Copy link
Member

@rsdmike rsdmike commented Aug 22, 2019

This PR updates test names that refer to the old naming style of the functions. It also address old function names that appear in the comments of code samples.

Signed-off-by: Mike Johanson [email protected]

Mike Johanson and others added 2 commits July 31, 2019 16:32
This PR updates test names that refer to the old naming style of the functions. It also address old function names that appear in the comments of code samples.

Signed-off-by: Mike Johanson <[email protected]>
@codecov-io
Copy link

Codecov Report

Merging #180 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #180   +/-   ##
=======================================
  Coverage   62.64%   62.64%           
=======================================
  Files          16       16           
  Lines         771      771           
=======================================
  Hits          483      483           
  Misses        261      261           
  Partials       27       27
Impacted Files Coverage Δ
appsdk/configurable.go 74.16% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 98dbf5a...3e16d90. Read the comment docs.

Copy link
Member

@lenny-goodell lenny-goodell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rsdmike rsdmike merged commit 1e73a11 into edgexfoundry:master Aug 22, 2019
@rsdmike rsdmike deleted the namingConsistency branch August 22, 2019 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants