feature(version): Add /api/version endpoint to SDK #156
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lenny-goodell
requested changes
Aug 2, 2019
Member
lenny-goodell
left a comment
lenny-goodell
left a comment
There was a problem hiding this comment.
Couple small changes needed
This endpoint will provide both version of the SDK that is in use as well as the version of the application service. These version values are intended to be set at build time leveraging -ldflags. closes #152 Signed-off-by: Mike Johanson <[email protected]>
rsdmike
force-pushed
the
versionEndpoint
branch
from
07e2eb9 to
d9fdfd0
Compare
Codecov Report
@@ Coverage Diff @@
## master #156 +/- ##
==========================================
+ Coverage 60.48% 61.03% +0.55%
==========================================
Files 14 14
Lines 706 716 +10
==========================================
+ Hits 427 437 +10
Misses 255 255
Partials 24 24
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This endpoint will provide both version of the SDK that is in use as well as the version of the application service. These version values are intended to be set at build time leveraging -ldflags.
closes #152
Signed-off-by: Mike Johanson [email protected]