Merged
Conversation
katexochen
force-pushed
the
p/aml-sandbox
branch
from
012e674 to
a0a3711
Compare
burgerdev
approved these changes
Mar 6, 2026
Member
burgerdev
left a comment
burgerdev
left a comment
There was a problem hiding this comment.
LGTM, thanks a lot, this is great!
Once you're done testing, you could consider squashing the AML code commits in the middle, because they are partially reverting themselves.
packages/by-name/kata/kernel-uvm/0001-drivers-acpi-add-BadAML-sandbox.patch
Outdated
Show resolved
Hide resolved
charludo
approved these changes
Mar 9, 2026
Collaborator
charludo
left a comment
charludo
left a comment
There was a problem hiding this comment.
I have looked esp. at the Nix and Go parts, which look good to me; can't really comment on the actual sandbox / C code.
katexochen
force-pushed
the
p/aml-sandbox
branch
from
a0a3711 to
b1398ac
Compare
Member
Author
|
Changed in last push:
|
burgerdev
approved these changes
Mar 10, 2026
Co-authored-by: Spyros Seimenis <sse@edgeless.systems>
Co-authored-by: Paul Meyer <katexochen0@gmail.com>
Co-authored-by: Spyros Seimenis <sse@edgeless.systems>
To reduce the dependency on the initrd start address, which changes based on various factors and cannot be predicted without starting a VM, we increase the file size of the target file and scan all the memory instead of just the initrd. This way we can get rid of the dependency on the initrd start address entirely.
and increase the size of the kernel ring buffer so that early messages don't dissapear. Co-authored-by: Paul Meyer <katexochen0@gmail.com>
katexochen
force-pushed
the
p/aml-sandbox
branch
from
b1398ac to
fe9a47c
Compare
Member
Author
|
Changed in last push:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.