Add explicit examples for numbers and text controls #935
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edgarmueller
suggested changes
Apr 12, 2018
Contributor
edgarmueller
left a comment
edgarmueller
left a comment
There was a problem hiding this comment.
Looks good, some remarks.
packages/examples/src/text.ts
Outdated
| { | ||
| type: 'Control', | ||
| scope: '#/properties/address', | ||
| label: 'Address', |
Contributor
There was a problem hiding this comment.
Explicitly point that this is using trim and restrict options
| @@ -0,0 +1,73 @@ | |||
| import { registerExamples } from './register'; | |||
|
|
|||
| export const schema = { | |||
Contributor
There was a problem hiding this comment.
Maybe we can pick a different example, since an address is not typically entered in a single text field. Also reduce the maxLength to a size of 10 which is beneficial when playing around with the examples.
packages/examples/src/numbers.ts
Outdated
| properties: { | ||
| price: { | ||
| type: 'number', | ||
| maximum: 300, |
| }; | ||
|
|
||
| export const uischema = { | ||
| type: 'VerticalLayout', |
Contributor
There was a problem hiding this comment.
Add controls for integer and number as well
Contributor
Author
|
updated |
edgarmueller
changed the title
edgarmueller
approved these changes
Apr 12, 2018
Contributor
|
Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added new example files to separate examples for numbers and texts.
Fix #865