Skip to content

Conversation

@sdirix
Copy link
Member

@sdirix sdirix commented May 30, 2025

The control description is already translated via JSON Forms core. The potentially translated description is now used instead of manually resolving the description from the schema.

Adds testcases.

The control description is already translated via JSON Forms core. The
potentially translated description is now used instead of manually
resolving the description from the schema.

Adds testcases.
@netlify
Copy link

netlify bot commented May 30, 2025

Deploy Preview for jsonforms-examples ready!

Name Link
🔨 Latest commit 7ef2b34
🔍 Latest deploy log https://app.netlify.com/projects/jsonforms-examples/deploys/683a0e13c7e8a000088ca12c
😎 Deploy Preview https://deploy-preview-2454--jsonforms-examples.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@sdirix sdirix requested a review from lucas-koehler May 30, 2025 19:59
@coveralls
Copy link

Coverage Status

coverage: 82.573%. remained the same
when pulling 7ef2b34 on sdirix:fix-angular-material-description
into d0b1dfa on eclipsesource:master.

Copy link
Contributor

@lucas-koehler lucas-koehler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@lucas-koehler lucas-koehler merged commit e9bd6a9 into eclipsesource:master Jun 13, 2025
8 checks passed
@lucas-koehler lucas-koehler added this to the 3.6 milestone Jun 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants