fix(angular): unsubscribe from jsonForm state subscription #2377
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the subscription to the jsonForm state in Angular was never unsubscribed. With this commit, all subscriptions will be unsubscribed when the component is destroyed. Closes eclipsesource#2354
✅ Deploy Preview for jsonforms-examples ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
sdirix
requested review from
lucas-koehler
and removed request for
lucas-koehler
Contributor
lucas-koehler
left a comment
lucas-koehler
left a comment
There was a problem hiding this comment.
Thanks for this PR @LukasBoll . The changes already look pretty good to me ✨
I have just two minor suggestions inline to make the base renderer's subscriptions protected.
lucas-koehler
approved these changes
Oct 10, 2024
laurentgrangier
pushed a commit
to codeblock-gmbh/jsonforms
that referenced
this pull request
Nov 26, 2024
…lipsesource#2377) Previously, subscriptions to the JSON Forms state in Angular were never removed when renderer components are destroyed. With this commit, all subscriptions will be unsubscribed when the component is destroyed. The base renderer offers an addSubscription method to register one or multiple subscriptions to automatically be unsubscribed on destroy. With this, extending renderers do not need to implement the unsubscribe again. Closes eclipsesource#2354 Co-authored-by: Lucas Koehler <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the subscription to the jsonForm state in Angular was never unsubscribed. With this commit, all subscriptions will be unsubscribed when the component is destroyed.
Closes #2354