dev: typescript 4.9.5, TS target ES2021, TS module ES2020, typedoc ~0.25.3 #2241
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….25.3 - Upgrade all packages to use typescript `~4.9.5` - Update typedoc version to `~0.25.3` and remove custom typedoc theme - Adapt @mui/icons-material imports in material-renderers to work with later typescript versions. The used imports broke starting with 4.2.4 - Fix typescript target from ESNext to ES2021 because - Fix typescript module from ESNext to ES2020 Remove ESNext from typescript configurations because it leads to changes in output when updating the typescript version. For `target` ESNext is explicitly discouraged in the typescript docs.
✅ Deploy Preview for jsonforms-examples ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
sdirix
reviewed
Jan 5, 2024
sdirix
approved these changes
Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
~4.9.5~0.25.3and remove custom typedoc themeRemove ESNext from typescript configurations because it leads to changes in output when updating the typescript version.
For
targetESNext is explicitly discouraged in the typescript docs. E.g. it broke vue linting when only upgrading the typescript version.