Skip to content

Conversation

@howdyAnkit
Copy link
Contributor

Fixes #1239

#1239

Fixed Jasmine test cases for one of the function
And added jasmine for the assigned Issue.

@netlify
Copy link

netlify bot commented Nov 20, 2023

Deploy Preview for jsonforms-examples ready!

Name Link
🔨 Latest commit c33c50d
🔍 Latest deploy log https://app.netlify.com/sites/jsonforms-examples/deploys/655afeb6c635d80008bf6766
😎 Deploy Preview https://deploy-preview-2217--jsonforms-examples.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@CLAassistant
Copy link

CLAassistant commented Nov 20, 2023

CLA assistant check
All committers have signed the CLA.

@sdirix
Copy link
Member

sdirix commented Nov 20, 2023

Thanks for the contribution ❤️

@coveralls
Copy link

Coverage Status

coverage: 85.286% (+0.8%) from 84.469%
when pulling c33c50d on howdyAnkit:jasmine-desolate
into 77624c6 on eclipsesource:master.

Copy link
Member

@sdirix sdirix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@howdyAnkit
Copy link
Contributor Author

Thanks for reviewing the PR brother ❤️

@sdirix sdirix merged commit 4098f62 into eclipsesource:master Dec 12, 2023
@howdyAnkit howdyAnkit deleted the jasmine-desolate branch December 12, 2023 14:46
@sdirix sdirix changed the title Fixes #1239 Add Angular Material Autocomplete test Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add tests for filtering in autocomplete renderer

4 participants