check if index of category is out of range #2121
Conversation
✅ Deploy Preview for jsonforms-examples ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
lucas-koehler
left a comment
lucas-koehler
left a comment
There was a problem hiding this comment.
Thanks for the PR :) I added a comment on avoiding introducing a useEffect and added a question.
packages/material-renderers/src/layouts/MaterialCategorizationLayout.tsx
Outdated
Show resolved
Hide resolved
packages/material-renderers/src/layouts/MaterialCategorizationLayout.tsx
Show resolved
Hide resolved
LukasBoll
force-pushed
the
categorisationAndSelection
branch
2 times, most recently
from
e163756 to
d35500b
Compare
lucas-koehler
left a comment
lucas-koehler
left a comment
There was a problem hiding this comment.
Thanks for the update. The example works well. I added a minor fix suggestion for the new file and added a question.
| </AppBar> | ||
| <div style={{ marginTop: '0.5em' }}> | ||
| <MaterialLayoutRenderer {...childProps} /> | ||
| <MaterialLayoutRenderer {...childProps} key={safeCategory} /> |
There was a problem hiding this comment.
What is the reason for adding this key? I don't think we need it.
There was a problem hiding this comment.
I think it always makes sense to set a new key and reset the state of all components, as we are working on different data once we change the tap. Also, we could run into similar issues with e.g. the detail list or expandable list, where the old state might not fit to the new data and the selected element is out of range.
There was a problem hiding this comment.
I feel it is not strictly necessary because the childProps should change anyway. But we can leave it in as it shouldn't hurt either :D
LukasBoll
force-pushed
the
categorisationAndSelection
branch
from
d35500b to
7a07554
Compare
lucas-koehler
left a comment
lucas-koehler
left a comment
There was a problem hiding this comment.
Thanks for the update, LGTM
| </AppBar> | ||
| <div style={{ marginTop: '0.5em' }}> | ||
| <MaterialLayoutRenderer {...childProps} /> | ||
| <MaterialLayoutRenderer {...childProps} key={safeCategory} /> |
There was a problem hiding this comment.
I feel it is not strictly necessary because the childProps should change anyway. But we can leave it in as it shouldn't hurt either :D
3 participants
closes #2111