Remove composition-api plugin & upgrade to vue 2.7 #1981
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
sdirix
reviewed
Jul 18, 2022
Member
sdirix
left a comment
sdirix
left a comment
There was a problem hiding this comment.
Looks good! Did not test it yet, just some questions and remarks.
Thanks for the contribution! ❤️
Comment on lines
1
to
3
| /** | ||
| * Switch between Vue 3 and Vue 2 '@vue/composition-api'. | ||
| */ |
Contributor
Author
Comment on lines
+62
to
+65
| "@vue/cli-plugin-babel": "~4.5.18", | ||
| "@vue/cli-plugin-typescript": "~4.5.18", | ||
| "@vue/cli-plugin-unit-jest": "~4.5.18", | ||
| "@vue/cli-service": "~4.5.18", |
Member
There was a problem hiding this comment.
Do we need to raise these dependencies? If yes please align them in the Vue 3 packages. If possible any dependency within the monorepo should be required in the same version.
Contributor
Author
There was a problem hiding this comment.
Yes it should be at least ~4.5.18 for v4 or ~5.0.6 for v5 . See here. I align the Vue 3 packages as well to ~4.5.18
| export { computed, defineComponent, inject, onBeforeMount, onUnmounted, reactive, ref, watch, watchEffect } from "vue"; | ||
| export type { Ref } from "vue"; | ||
| /** | ||
| * Compatibility type as defineComponent of '@vue/composition-api' can't properly handle PropTypes. |
sdirix
approved these changes
Jul 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1978