Skip to content

Conversation

@lucas-koehler
Copy link
Contributor

When no views to show for date and/or time controls are specified in the UI Schema, explicitly hand in the default ones.

This ensures consitent behavior if the internal default of the material controls changes and avoids type errors on undefined views arrays.

When no views to show for date and/or time controls are specified in the UI Schema, explicitly hand in the default ones.

This ensures consitent behavior if the internal default of the material controls changes and avoids type errors on undefined views arrays.
@lucas-koehler lucas-koehler requested a review from sdirix June 21, 2022 15:28
@coveralls
Copy link

Coverage Status

Coverage remained the same at 84.098% when pulling fd5777d on material-date-time-default-views into 31972a5 on master.

Copy link
Member

@sdirix sdirix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sdirix sdirix merged commit 23a3a9e into master Jun 26, 2022
@sdirix sdirix linked an issue Jun 26, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

date-time format material renderer crashes

4 participants