Handle recursive combinators based schemas #1255
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Re-structure combinator renderers, so that subschemas are passed to sub-sequent JsonForms calls * Fix path of oneOf renderer * Use title property if available for displaying oneOf subschemas * Consistent usage of schema & rootSchema, remove scopedSchema prop * Refactor mapStateToFieldProps
edgarmueller
force-pushed
the
fix/one-of-issues
branch
from
3d97064 to
6a5935c
Compare
sdirix
approved these changes
Feb 13, 2019
Member
sdirix
left a comment
sdirix
left a comment
There was a problem hiding this comment.
The code looks good to me. Because of the size of the change I wasn't able to look at each changed line specifically, but the overall architecture change looks fine to me. I also run the material and angular-material examples and everything looked fine to me.
Some more work is needed, for example for the one-of titles and customizing of the all-of renderer, but these are definitely follow up issues.
|
|
||
| /** | ||
| * Resolve the given schema path in order to obtain a subschema. | ||
| * @param {JsonSchema} schema the root schema from which to start |
Member
There was a problem hiding this comment.
the (sub-)schema from which to start
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry, this change got a bit out-of-hand because of updating the tests. If necessary, I can split it up into multipe commits.
sub-sequent JsonForms calls