Skip to content

[react] Allow renderers ownProp to be passed to JsonForms component #1246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 28, 2019
Merged

[react] Allow renderers ownProp to be passed to JsonForms component #1246

merged 1 commit into from
Jan 28, 2019

Conversation

@edgarmueller
Copy link
Contributor

@edgarmueller edgarmueller commented Jan 28, 2019

No description provided.

@edgarmueller edgarmueller added this to the 2.2.0 milestone Jan 28, 2019
@edgarmueller edgarmueller requested a review from sdirix January 28, 2019 13:36
@coveralls
Copy link

coveralls commented Jan 28, 2019

Coverage Status

Coverage increased (+0.01%) to 88.326% when pulling 8a0f569 on edgarmueller:fix/react/ownProps-renderers into 250a6fa on eclipsesource:master.

sdirix
sdirix approved these changes Jan 28, 2019
View reviewed changes
Copy link
Member

@sdirix sdirix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@edgarmueller edgarmueller merged commit cb9fd29 into eclipsesource:master Jan 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sdirix sdirix sdirix approved these changes

Assignees

No one assigned

Labels

react

Projects

None yet

Milestone

2.2.0

Development

Successfully merging this pull request may close these issues.

3 participants

@edgarmueller @coveralls @sdirix