Add 1st draft of ionic renderer set #1015
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eneufeld
reviewed
Jun 28, 2018
Member
eneufeld
left a comment
eneufeld
left a comment
There was a problem hiding this comment.
Code looks good.
I still need to execute it.
| ); | ||
| this.subscription = state$.subscribe(props => { | ||
| const {renderers, schema, uischema} = props as JsonFormsProps; | ||
| const { renderers } = props as JsonFormsProps; |
Member
There was a problem hiding this comment.
why retrieve the renderers at all?
| import { Subscription } from 'rxjs/Subscription'; | ||
| import { FormControl } from '@angular/forms'; | ||
|
|
||
| export class JsonFormsIonicControl extends JsonFormsBaseRenderer implements OnInit, OnDestroy { |
Member
There was a problem hiding this comment.
shouldn't this be part of the angular core?
I don't see anything ionic specific about this
| }) | ||
| export class GroupLayoutRenderer extends JsonFormsIonicLayout { | ||
|
|
||
| @Input() path: string; |
Member
There was a problem hiding this comment.
why does the group need an own path and the other layouts don't?
| LabelRenderer | ||
| ], | ||
| providers: [ | ||
| MasterDetailNavService |
Member
There was a problem hiding this comment.
isn't MasterDetailComponent the only user?
why not let it provide the service?
eneufeld
approved these changes
Jun 28, 2018
Member
eneufeld
left a comment
eneufeld
left a comment
There was a problem hiding this comment.
Besides the other small annotations this looks good.
Can we maybe move the package updates of the non ionic packages in a separate commit?
edgarmueller
force-pushed
the
feature/ionic-renderer-set
branch
from
8cbff06 to
cecbd53
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.