Skip to content

Allow overriding options in EnumField #1002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 12, 2018
Merged

Allow overriding options in EnumField #1002

merged 1 commit into from
Jun 12, 2018
+194 −26

Conversation

@AhmetTanakol
Copy link
Contributor

@AhmetTanakol AhmetTanakol commented Jun 11, 2018

Create a new mapStateToProps and use enum props as default property to populate data for enum fields

@coveralls
Copy link

coveralls commented Jun 11, 2018 •
edited
Loading

Coverage Status

Coverage increased (+0.08%) to 87.7% when pulling a28cb43 on AhmetTanakol:enum-field into 3289342 on eclipsesource:master.

edgarmueller
edgarmueller approved these changes Jun 12, 2018
View reviewed changes
Copy link
Contributor

@edgarmueller edgarmueller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks for adding the test as well!

@edgarmueller edgarmueller merged commit ade0da0 into eclipsesource:master Jun 12, 2018
@edgarmueller edgarmueller added this to the 2.0.2 milestone Jun 12, 2018
@edgarmueller edgarmueller changed the title EnumField refactor Allow overriding options in EnumField Jun 18, 2018
@AhmetTanakol AhmetTanakol deleted the enum-field branch June 20, 2018 08:31
eneufeld pushed a commit to eneufeld/jsonforms that referenced this pull request Jun 21, 2018
@Ahmetanakol @eneufeld
Allow overriding options prop of enum field renderer (eclipsesource#1002
9490f8a 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@edgarmueller edgarmueller edgarmueller approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2.0.2

Development

Successfully merging this pull request may close these issues.

4 participants

@AhmetTanakol @coveralls @edgarmueller @Ahmetanakol