Skip to content

Conversation

@AndrienkoAleksandr
Copy link
Contributor

@AndrienkoAleksandr AndrienkoAleksandr commented Feb 5, 2020

Referenced issue
issue: eclipse-che/che#15493

What does this PR do?
Continue work started #137 :

  • create che-workspace SA only for single workspace namespaces strategy
  • check what namespace we're using for workspaces (workspaceNamespaceDefault)
    • if it is different than che-operator is deployed to, create all ClusterRoles and ClusterRoleBindings needed to create new namespaces and to create workspaces in them
    • if it is same as che-operator's namespace, create just Role and RoleBinding needed to manage workspaces in same namespace
  • if oauth is enabled, just create che sa with edit, exec, view permissions.
  • finalize cluster roles and cluster role bindings created by che-operator for Che server
  • make working Che server property CHE_INFRA_KUBERNETES_CLUSTER__ROLE__NAME

Related pr(s)
che-incubator/chectl#469

TODO:

  • test and fix permissions for k8s (currently it works for openshift)
  • test with OS Oauth. PR does not grant any permissions for che sa
  • check chectl
  • test installation with olm

sparkoo and others added 15 commits December 3, 2019 16:19
Signed-off-by: Michal Vala <[email protected]>
Signed-off-by: Michal Vala <[email protected]>
Fix failing workspace start due 'update' namespace permission. Handle todo about saving Che worksapce cluster role property to config map. Rename che cluster role to che-manage-namespaces

Signed-off-by: Oleksandr Andriienko <[email protected]>
…the minikube: create own unique clusterrole and clusterrolebinding for Che server. We need it if we want to have working few che in the same cluster in the different namespaces.

Signed-off-by: Oleksandr Andriienko <[email protected]>
Signed-off-by: Oleksandr Andriienko <[email protected]>
Signed-off-by: Oleksandr Andriienko <[email protected]>
@che-bot
Copy link
Contributor

che-bot commented Feb 5, 2020

Can one of the admins verify this patch?

@AndrienkoAleksandr AndrienkoAleksandr changed the title Che 15493 CHE-15493: <username>-che as default namespace Feb 5, 2020
@AndrienkoAleksandr
Copy link
Contributor Author

CI errors on start workspaces again due image hash for che-theia: eclipse-che/che#18931

Signed-off-by: Oleksandr Andriienko <[email protected]>
Signed-off-by: Oleksandr Andriienko <[email protected]>
Signed-off-by: Oleksandr Andriienko <[email protected]>
Signed-off-by: Oleksandr Andriienko <[email protected]>
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: AndrienkoAleksandr, sparkoo, tolusha
To complete the pull request process, please assign after the PR has been reviewed.
You can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Oleksandr Andriienko <[email protected]>
@openshift-ci-robot
Copy link

New changes are detected. LGTM label has been removed.

Signed-off-by: Oleksandr Andriienko <[email protected]>
Copy link
Member

@sparkoo sparkoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just taking my approval down as today is it's 1st birthday and a lot of changed since then :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants