Fix ESP-IDF CI build#1218
Open
gmartin82 wants to merge 1 commit intoeclipse-zenoh:mainfrom
Open
Conversation
40f117b to
b7e8d55
Compare
a15460c to
b665696
Compare
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix PlatformIO source filtering so platform-specific backend files are selected consistently with the CMake platform profiles.
PlatformIO was auto-discovering sources outside
src/system/**, including platform-specific transport backends undersrc/link/transport/**. This meant builds could include sources for the wrong platform, for example ESP-IDF builds attempting to compile Arduino ESP32 C++ transport files.What does this PR do?
This PR updates
extra_script.pyto:cmake/platforms/<platform>.cmake;ZP_PLATFORM_SOURCE_FILESlisted by that CMake profile;Why is this change needed?
The previous PlatformIO filter treated
src/system/**as the platform-specific boundary, but the platform-composition rework also has platform-specific files undersrc/link/transport/**, such as Arduino ESP32 Bluetooth and serial sources.Because PlatformIO starts from
+<*>, those files could be picked up even when the active platform profile did not select them. This caused incorrect cross-platform compilation, for example ESP-IDF builds trying to compile Arduino-specific C++ files.Deriving the PlatformIO filter from the CMake platform profile avoids duplicating the source list in
extra_script.pyand keeps PlatformIO aligned with the existing CMake platform selection.Related Issues
Related to PlatformIO build failures where ESP-IDF attempted to compile Arduino ESP32 transport sources.
🏷️ Label-Based Checklist
Based on the labels applied to this PR, please complete these additional requirements:
Labels:
internal🏠 Internal Change
This PR is marked as internal (not user-facing):
Lighter review: Internal changes may have lighter review requirements.
Instructions:
- [ ]to- [x])This checklist updates automatically when labels change, but preserves your checked boxes.