[tycho-4.0.x] Use the new MavenDependencyCollector shared with m2e#4749
Merged
eclipse-tycho-bot merged 1 commit intotycho-4.0.xfrom Feb 24, 2025
Merged
[tycho-4.0.x] Use the new MavenDependencyCollector shared with m2e#4749eclipse-tycho-bot merged 1 commit intotycho-4.0.xfrom
eclipse-tycho-bot merged 1 commit intotycho-4.0.xfrom
Conversation
Currently Tycho uses the usual maven resolver to find transitive dependencies but this works differently than what we want here. Instead we want all dependencies and their dependencies and then filter for the given scopes provided if any match.As this is a non trivial operation, it seems useful to make the code also sharable with Tycho so we ensure there is always the same result in Tycho as in m2e. This now uses the new MavenDependencyCollector that is shared with Tm2e that traverses the dependency tree in a way we need here and collects everything along the way. This also has the advantage, that if we choose to only collect direct dependencies, not the whole tree has to be traversed as before. (cherry picked from commit 0e2d268)
Test Results 606 files 606 suites 4h 8m 50s ⏱️ Results for commit e37c2d8. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
maintotycho-4.0.x:Questions ?
Please refer to the Backport tool documentation